Add some script tests #12425
Merged
Add some script tests #12425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Why is it necessary to check for negative 0? |
Member
|
utACK, thanks for adding tests!
Because the point of these tests is to cover as many as possible inputs, including weird/unexpected encodings of values. |
Contributor
Author
|
I thought I'd found some mismatches between bitcoind's consensus mechanims and pycoin's, so I wrote these tests to check. Turns out pycoin was working properly, but I thought I'd submit the tests anyway. |
Contributor
|
@laanwj Okay, that answers my question and it makes sense. Thank you. |
randolf
approved these changes
Feb 15, 2018
laanwj
added a commit
that referenced
this pull request
Feb 16, 2018
be45a67 Add some script tests related to BOOL ops and odd values like negative 0. (Richard Kiss) Pull request description: Add some script tests related to BOOL ops and odd values like negative 0. Tree-SHA512: 8e633f7ea5eea39e31016994baf60f295fa1dc8cae27aa5fcfc741ea97136bfb3ddc57bb62b9c6bf9fe256fc09cdd184906ba8e611e297cf8d2d363da2bbf1d4
azuchi
pushed a commit
to chaintope/bitcoinrb
that referenced
this pull request
Feb 26, 2018
braydonf
added a commit
to braydonf/bcoin
that referenced
this pull request
Feb 2, 2019
braydonf
added a commit
to braydonf/bcoin
that referenced
this pull request
Feb 2, 2019
tuxcanfly
pushed a commit
to tuxcanfly/bcoin
that referenced
this pull request
Apr 19, 2019
dagurval
pushed a commit
to dagurval/BitcoinUnlimited
that referenced
this pull request
Aug 28, 2019
gandrewstone
pushed a commit
to BitcoinUnlimited/BitcoinUnlimited
that referenced
this pull request
Aug 30, 2019
* Tests for signature length to script_tests Partial pick of: Add SCRIPT_ENABLE_SCHNORR support to sigencoding https://reviews.bitcoinabc.org/D2469 * Add some script tests related to BOOL ops and odd values like negative 0. bitcoin/bitcoin#12425 * Partial cherry-pick of "Fixed multiple typos" bitcoin/bitcoin#10633
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 17, 2020
be45a67 Add some script tests related to BOOL ops and odd values like negative 0. (Richard Kiss) Pull request description: Add some script tests related to BOOL ops and odd values like negative 0. Tree-SHA512: 8e633f7ea5eea39e31016994baf60f295fa1dc8cae27aa5fcfc741ea97136bfb3ddc57bb62b9c6bf9fe256fc09cdd184906ba8e611e297cf8d2d363da2bbf1d4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some script tests related to BOOL ops and odd values like negative 0.