Skip to content

Conversation

@practicalswift
Copy link
Contributor

Fix Windows build errors introduced in #10498

Fixes #12386

cc @ken2812221, @Sjors, @MarcoFalke and @floreslorca

@maflcko
Copy link
Member

maflcko commented Feb 12, 2018

utACK f40df29

@Sjors
Copy link
Member

Sjors commented Feb 12, 2018

Tested on a Gitian VM:

cd bitcoin
git remote add practicalswift https://github.com/practicalswift/bitcoin
git fetch practicalswift
cd ..
./gitian-build.sh -u https://github.com/practicalswift/bitcoin --detach-sign -c -b -o w sjors fix-windows-build
fix-windows-build

Build succeeds, but I do see some warnings (not sure if related), e.g.:

In file included from /home/ubuntu/build/bitcoin/depends/i686-w64-mingw32/share/../include/boost/thread/win32/condition_variable.hpp:9:0,
                 from /home/ubuntu/build/bitcoin/depends/i686-w64-mingw32/share/../include/boost/thread/condition_variable.hpp:14,
                 from ./util.h:31,
                 from ./addrman.h:14,
                 from init.cpp:12:
/home/ubuntu/build/bitcoin/depends/i686-w64-mingw32/share/../include/boost/thread/win32/thread_primitives.hpp:177:55: warning: conflicts with previous declaration ‘void* boost::detail::win32::GetModuleHandleA(const char*)’ [enabled by default]
                 __declspec(dllimport) void* __stdcall GetModuleHandleA(char const*);                             

I copied the executables over to a Windows 10 VM and was able to launch QT.

@bitcoin bitcoin deleted a comment from ushan007 Feb 12, 2018
@maflcko maflcko merged commit f40df29 into bitcoin:master Feb 12, 2018
maflcko pushed a commit that referenced this pull request Feb 12, 2018
f40df29 Fix Windows build errors introduced in #10498 (practicalswift)

Pull request description:

  Fix Windows build errors introduced in #10498

  Fixes #12386

  cc @ken2812221, @Sjors, @MarcoFalke and @floreslorca

Tree-SHA512: a807521fbd4015971e646fa4bab5495a3aaa97337e7b7d80b9161f33778e84ad6725cf4fbd5a35b50bf3a2bd97747cd7a630b51493ff516c2e1ad74acce148be
@maflcko maflcko added GUI and removed Refactoring labels Feb 12, 2018
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 11, 2020
…0498

f40df29 Fix Windows build errors introduced in bitcoin#10498 (practicalswift)

Pull request description:

  Fix Windows build errors introduced in bitcoin#10498

  Fixes bitcoin#12386

  cc @ken2812221, @Sjors, @MarcoFalke and @floreslorca

Tree-SHA512: a807521fbd4015971e646fa4bab5495a3aaa97337e7b7d80b9161f33778e84ad6725cf4fbd5a35b50bf3a2bd97747cd7a630b51493ff516c2e1ad74acce148be
@practicalswift practicalswift deleted the fix-windows-build branch April 10, 2021 19:33
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows Build Error

4 participants