Skip to content

Fix a-vs-an typos #12393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Feb 12, 2018
Merged

Fix a-vs-an typos #12393

laanwj merged 1 commit into from
Feb 12, 2018

Conversation

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Feb 9, 2018

Fix a-vs-an typos.

@fanquake fanquake added the Docs label Feb 9, 2018
promag
promag reviewed Feb 9, 2018
View reviewed changes
Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

src/script/ismine.h Outdated
Copy link
Contributor

@promag promag Feb 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove an?

Copy link
Contributor Author

@practicalswift practicalswift Feb 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed!

@practicalswift practicalswift force-pushed the a-vs-an-typos branch 2 times, most recently from 17b75fb to f88597a Compare February 9, 2018 12:44
randolf
randolf suggested changes Feb 9, 2018
View reviewed changes
Copy link
Contributor

@randolf randolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK for 11 out of 12 changes...

NACK for 1 change in src/reverselock.h because the original "An RAII-style" is actually correct since acronyms tend to be read out letter-by-letter and the word "An" flows more easily and correctly when reading out loud.

@practicalswift
Copy link
Contributor Author

practicalswift commented Feb 9, 2018

@randolf Good point about RAII. Fixed. Please re-review :-)

@randolf
Copy link
Contributor

randolf commented Feb 9, 2018

@practicalswift I don't see the fix yet, but perhaps GitHub just needs some time to synchronize. I'll check again later and approve once the fix appears. Thanks for the quick turn-around.

@randolf
Copy link
Contributor

randolf commented Feb 10, 2018

@practicalswift I just asked some other developers about this, and they suspect that you may need to "push" your changes so that they'll appear here.

@jonasschnelli
Copy link
Contributor

jonasschnelli commented Feb 10, 2018

Meh ACK f88597ad01eb8e6b872f5fc6a0bb04b17689542c

@practicalswift
Copy link
Contributor Author

practicalswift commented Feb 10, 2018

@randolf Oh, I forgot to push after changing. Thanks for letting me know! Please re-review :-)

@maflcko
Copy link
Member

maflcko commented Feb 10, 2018

Travis fails with FAIL: subtree directory was touched without subtree merge

@practicalswift
Copy link
Contributor Author

practicalswift commented Feb 11, 2018

Removed the change to src/univalue/ since that one should be reported upstream instead.

Please re-review :-)

luke-jr
luke-jr approved these changes Feb 12, 2018
View reviewed changes
Copy link
Member

@luke-jr luke-jr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@laanwj laanwj merged commit 11376b5 into bitcoin:master Feb 12, 2018
laanwj added a commit that referenced this pull request Feb 12, 2018
@laanwj
Merge #12393: Fix a-vs-an typos
108af52 
11376b5 Fix a-vs-an typos (practicalswift)

Pull request description:

  Fix a-vs-an typos.

Tree-SHA512: 2cf74c15656a20ec13d2da7d86a39d14e634db368833d92da06a78d1266950accfc4fcc89cfecdaadd46e6b48b17e6fad29080428e564871e78482c53f3e855c
braydonf added a commit to braydonf/bcoin that referenced this pull request Feb 2, 2019
@braydonf
script: update tx standardness rules and more tx tests
e866da8 
References:
- bitcoin/bitcoin#11423
- bitcoin/bitcoin#12600
- bitcoin/bitcoin#12082

Trivial References:
- bitcoin/bitcoin#12393
- bitcoin/bitcoin#6539
- bitcoin/bitcoin#10742
- bitcoin/bitcoin@ecb11f5
braydonf added a commit to braydonf/bcoin that referenced this pull request Feb 2, 2019
@braydonf
script: update tx standardness rules and more tx tests
efa7810 
References:
- bitcoin/bitcoin#11423
- bitcoin/bitcoin#12600
- bitcoin/bitcoin#12082

Trivial References:
- bitcoin/bitcoin#12393
- bitcoin/bitcoin#6539
- bitcoin/bitcoin#10742
- bitcoin/bitcoin@ecb11f5
tuxcanfly pushed a commit to tuxcanfly/bcoin that referenced this pull request Apr 19, 2019
@braydonf @tuxcanfly
script: update tx standardness rules and more tx tests
586fef8 
References:
- bitcoin/bitcoin#11423
- bitcoin/bitcoin#12600
- bitcoin/bitcoin#12082

Trivial References:
- bitcoin/bitcoin#12393
- bitcoin/bitcoin#6539
- bitcoin/bitcoin#10742
- bitcoin/bitcoin@ecb11f5
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 17, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#12393: Fix a-vs-an typos
9b0c1f7 
11376b5 Fix a-vs-an typos (practicalswift)

Pull request description:

  Fix a-vs-an typos.

Tree-SHA512: 2cf74c15656a20ec13d2da7d86a39d14e634db368833d92da06a78d1266950accfc4fcc89cfecdaadd46e6b48b17e6fad29080428e564871e78482c53f3e855c
@practicalswift practicalswift deleted the a-vs-an-typos branch April 10, 2021 19:33
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Mar 8, 2022
@laanwj @gades
Merge bitcoin#12393: Fix a-vs-an typos
b251781 
11376b5 Fix a-vs-an typos (practicalswift)

Pull request description:

  Fix a-vs-an typos.

Tree-SHA512: 2cf74c15656a20ec13d2da7d86a39d14e634db368833d92da06a78d1266950accfc4fcc89cfecdaadd46e6b48b17e6fad29080428e564871e78482c53f3e855c
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@promag promag promag left review comments

@luke-jr luke-jr luke-jr approved these changes

@randolf randolf randolf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@practicalswift @randolf @jonasschnelli @maflcko @luke-jr @promag @laanwj @fanquake