RPC: Consistently use UniValue.pushKV instead of push_back(Pair()) (karel-3d) #12193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tested ACK cf931d8 |
maflcko
force-pushed
the
Mf1801-univalueDeprecatedPair
branch
3 times, most recently
from
e50a451 to
b7de633
Compare
Member
Author
|
Rebased |
dcousens
approved these changes
Feb 7, 2018
Contributor
|
tested ACK b7de633eb2105758d8d92089a0dbcaba23eea5d0 |
added 2 commits
February 10, 2018 09:55
maflcko
force-pushed
the
Mf1801-univalueDeprecatedPair
branch
2 times, most recently
from
fb0ef80 to
42e8ad3
Compare
-BEGIN VERIFY SCRIPT- git grep -l "push_back(Pair" | xargs sed -i "s/push_back(Pair(\(.*\)));/pushKV(\1);/g" -END VERIFY SCRIPT-
maflcko
force-pushed
the
Mf1801-univalueDeprecatedPair
branch
from
42e8ad3 to
91986ed
Compare
Member
Author
|
Rebased. This is a subtree bump and simple scripted diff. Should be trivial to review. |
Closed
maflcko
pushed a commit
that referenced
this pull request
Feb 12, 2018
…ack(Pair()) (karel-3d) 91986ed scripted-diff: Use UniValue.pushKV instead of push_back(Pair()) (Karel Bilek) a570098 Squashed 'src/univalue/' changes from 07947ff2da..51d3ab34ba (MarcoFalke) Pull request description: Rebased version of #11386 by karel-3d. Closes: #11386 Tree-SHA512: f3a81447e573c17e75813f4d41ceb34b9980eac81efdd98ddb149d7c51f792be7e2b32239b6ea7e6da68af23897afa6b4ce3f4e8070f9c4adf5105bf6075f2a0
laanwj
added a commit
that referenced
this pull request
Mar 14, 2018
8172d3a configure: UniValue 1.0.4 is required for pushKV(, bool) (Luke Dashjr) Pull request description: The breaking changes (#12193) are already merged, so this blocks 0.17.0. It depends on jgarzik/univalue#42 or jgarzik/univalue#50 being merged and released in UniValue 1.0.4. Tree-SHA512: 3a21bbc72d6632bd07ee60ad7780b9ee95908357bcf59b4795b693d8a5d8c88943d6451482f11916ff5417e3bdbb9916062f87d0d73e79f50eb95ddabe21f943
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 13, 2020
…(, bool) 8172d3a configure: UniValue 1.0.4 is required for pushKV(, bool) (Luke Dashjr) Pull request description: The breaking changes (bitcoin#12193) are already merged, so this blocks 0.17.0. It depends on jgarzik/univalue#42 or jgarzik/univalue#50 being merged and released in UniValue 1.0.4. Tree-SHA512: 3a21bbc72d6632bd07ee60ad7780b9ee95908357bcf59b4795b693d8a5d8c88943d6451482f11916ff5417e3bdbb9916062f87d0d73e79f50eb95ddabe21f943
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 16, 2020
…itcoin#12193) -BEGIN VERIFY SCRIPT- git grep -l "push_back(Pair" | xargs sed -i "s/push_back(Pair(\(.*\)));/pushKV(\1);/g" -END VERIFY SCRIPT- Signed-off-by: pasta <[email protected]>
UdjinM6
pushed a commit
to dashpay/dash
that referenced
this pull request
Jun 18, 2020
…f push_back(Pair()) (karel-3d) (#3532) * Begin Merge 12193 Squashed 'src/univalue/' changes from 07947ff2da..51d3ab34ba 51d3ab34ba Merge #10: Add pushKV(key, boolean) function (replaces #5) 129bad96d5 [tests] test pushKV for boolean values b3c44c947f Pushing boolean value to univalue correctly git-subtree-dir: src/univalue git-subtree-split: 51d3ab34ba2857f0d03dc07250cb4a2b5e712e67 * scripted-diff: Use UniValue.pushKV instead of push_back(Pair()) (end bitcoin#12193) -BEGIN VERIFY SCRIPT- git grep -l "push_back(Pair" | xargs sed -i "s/push_back(Pair(\(.*\)));/pushKV(\1);/g" -END VERIFY SCRIPT- Signed-off-by: pasta <[email protected]> Co-authored-by: MarcoFalke <[email protected]>
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 19, 2020
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Jan 28, 2021
Update UniValue subtree This brings us up-to-date with upstream Bitcoin's version of the library. Includes a commit cherry-picked from bitcoin/bitcoin#12193.
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Jun 26, 2021
…(, bool) 8172d3a configure: UniValue 1.0.4 is required for pushKV(, bool) (Luke Dashjr) Pull request description: The breaking changes (bitcoin#12193) are already merged, so this blocks 0.17.0. It depends on jgarzik/univalue#42 or jgarzik/univalue#50 being merged and released in UniValue 1.0.4. Tree-SHA512: 3a21bbc72d6632bd07ee60ad7780b9ee95908357bcf59b4795b693d8a5d8c88943d6451482f11916ff5417e3bdbb9916062f87d0d73e79f50eb95ddabe21f943
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of #11386 by karel-3d.
Closes: #11386