Make segwit failure due to CLEANSTACK violation return a SCRIPT_ERR_CLEANSTACK error code #12167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LEANSTACK error code.
Contributor
|
utack 1e747e3 |
instagibbs
approved these changes
Jan 12, 2018
Member
instagibbs
left a comment
instagibbs
left a comment
There was a problem hiding this comment.
utACK
sidenote: I do wonder what "implicit" here means in the commend above. Implicit since no flag is passed, I suppose?
Member
|
utACK |
Member
|
utACK 1e747e3. @instagibbs Yes, I read that as "if we're into witness validation, SCRIPT_VERIFY_CLEANSTACK is assumed" |
Member
|
it's more "if we're into witness validation, cleanstack is implied (regardless of SCRIPT_VERIFY_CLEANSTACK)" |
Contributor
|
utACK |
Contributor
|
Concept ACK. |
Contributor
|
5 utACKs. Is this ready for merge? |
sipa
added a commit
that referenced
this pull request
Apr 5, 2018
…a SCRIPT_ERR_CLEANSTACK error code 1e747e3 Make segwit failure due to CLEANSTACK violation return a SCRIPT_ERR_CLEANSTACK error code. (Mark Friedenbach) Pull request description: If a segwit script terminates with a stack size not equal to one, the current error code is EVAL_FALSE. This is semantically wrong, and prevents explicitly checking CLEANSTACK violations in the unit tests. This PR changes the error code (and affected unit tests) to use SCRIPT_ERROR_CLEANSTACK instead of SCRIPT_ERROR_EVAL_FALSE. Tree-SHA512: 8f7b1650f7a23a942cde1070e3e56420be456b4a7be42515b237e95557bf2bd5e7ba9aabd213c8092bea28c165dbe73f5a3486300089aeb01e698151b42484b1
braydonf
added a commit
to braydonf/bcoin
that referenced
this pull request
Feb 2, 2019
braydonf
added a commit
to braydonf/bcoin
that referenced
this pull request
Feb 2, 2019
tuxcanfly
pushed a commit
to tuxcanfly/bcoin
that referenced
this pull request
Apr 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a segwit script terminates with a stack size not equal to one, the current error code is EVAL_FALSE. This is semantically wrong, and prevents explicitly checking CLEANSTACK violations in the unit tests. This PR changes the error code (and affected unit tests) to use SCRIPT_ERROR_CLEANSTACK instead of SCRIPT_ERROR_EVAL_FALSE.