Skip to content

Conversation

@jackycjh
Copy link
Contributor

@jackycjh jackycjh commented Jan 8, 2018

This resolves #11861 (A confusion caused by incorrect information in the release notes).

More information can be found at #11861.

@fanquake fanquake added the Docs label Jan 8, 2018
@promag
Copy link
Contributor

promag commented Jan 8, 2018

Do we fix release notes?

@DuncanBetts
Copy link

I would imagine the intent of release notes is to support a release, by providing accurate information about it. So, my opinion would be that we should. Happy to hear arguments against :).

@laanwj
Copy link
Member

laanwj commented Jan 11, 2018

Normally I'm against changing release notes after a release. They have been copied to many places, in mail, other sites. So it's like closing the barn after the horse left.

But I'm okay with changing this as the examples are really wrong. I'm surprised no one discovered this sooner.

@laanwj laanwj merged commit 2be2b5d into bitcoin:master Jan 11, 2018
laanwj added a commit that referenced this pull request Jan 11, 2018
2be2b5d Remove the ending slashes from RPC URI format. (Jacky C)

Pull request description:

  This resolves #11861 (A confusion caused by incorrect information in the release notes).

  More information can be found at #11861.

Tree-SHA512: 35f85854b01a84acd5358e0c9deff881205111120277fa7cdf270801933c2603c2ae04fa4d55d233675c7298c2d37cc60c919f89e7e6091f5c61884025775ab0
@ryanofsky
Copy link
Contributor

I'm surprised no one discovered this sooner.

Heh, I'm not surprised by this at all. While we were discussing this change (admittedly, I was against it), I asked repeatedly for documentation to be written to accompany it because I thought the usage was complex and confusing.

I think it's best when documentation and code changes are made at the same time. It prevents mistakes, makes code easier to review, and can even lead to better designs because often writing documentation causes you to look at things from a different perspective.

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multi-wallet RPC URI parsing invalid when ending with a slash

6 participants