Add support to search the address book #12080
Conversation
promag
force-pushed
the
2018-01-searchaddressbook
branch
from
14b6d4d to
c316fdf
Compare
|
Concept ACK |
|
Should we really be adding more functionality that encourages address reuse instead of doing the opposite? |
|
@gmaxwell I see your point. Although, from the UI point of view, search/filter is a basic thing to have near big lists. |
Sjors
left a comment
Sjors
left a comment
There was a problem hiding this comment.
Perhaps in the future the address book can be used for something more privacy friendly (in other words, not literally addresses). In addition, maybe the address book and/or send screen can mark used addresses as such.
Looks like a simple enough change code-wise.
Tested, worked for me.
| proxyModel->setDynamicSortFilter(true); | ||
| proxyModel->setSortCaseSensitivity(Qt::CaseInsensitive); | ||
| proxyModel->setFilterCaseSensitivity(Qt::CaseInsensitive); | ||
| switch(tab) |
There was a problem hiding this comment.
This behaviour is now coded in L151.
There was a problem hiding this comment.
I see. In that case I'm confused as to what ReceivingTab does. I only see the address book in the Send tab.
There was a problem hiding this comment.
Create a request payments in "Receive" tab and then go "File" -> "Receiving adresses...".
There was a problem hiding this comment.
Found it, search works there as well.
|
ACK c316fdf. Suggestion for future improvement: highlight matching characters using bold font. |
c316fdf [qt] Add support to search the address book (João Barbosa) Pull request description: This PR adds support to search the address book for both receiving and sending addresses. A specialisation of the `QSortFilterProxyModel` is added to implement the custom filtering. <img width="757" alt="screen shot 2018-01-03 at 16 05 57" src="https://user-images.githubusercontent.com/3534524/34528196-0347d61e-f0a0-11e7-9bd3-535e9e34ceb8.png"> <img width="759" alt="screen shot 2018-01-03 at 16 00 58" src="https://user-images.githubusercontent.com/3534524/34528202-07c99f24-f0a0-11e7-8e34-cff6a1ba2364.png"> Closes #623. Tree-SHA512: 316e646015c858fc70db6be72dc7922d5bb10a3399e7fa327c992e184cc37a124f11cffefab2dbe0d16bda790c7c0437db364686e66c40b4054b8250b4be15d0
c316fdf [qt] Add support to search the address book (João Barbosa) Pull request description: This PR adds support to search the address book for both receiving and sending addresses. A specialisation of the `QSortFilterProxyModel` is added to implement the custom filtering. <img width="757" alt="screen shot 2018-01-03 at 16 05 57" src="https://user-images.githubusercontent.com/3534524/34528196-0347d61e-f0a0-11e7-9bd3-535e9e34ceb8.png"> <img width="759" alt="screen shot 2018-01-03 at 16 00 58" src="https://user-images.githubusercontent.com/3534524/34528202-07c99f24-f0a0-11e7-8e34-cff6a1ba2364.png"> Closes dashpay#623. Tree-SHA512: 316e646015c858fc70db6be72dc7922d5bb10a3399e7fa327c992e184cc37a124f11cffefab2dbe0d16bda790c7c0437db364686e66c40b4054b8250b4be15d0
6 participants
This PR adds support to search the address book for both receiving and sending addresses.
A specialisation of the
QSortFilterProxyModelis added to implement the custom filtering.Closes #623.