Skip to content

Conversation

@achow101
Copy link
Member

@achow101 achow101 commented Dec 26, 2017

This will show accurate and correct timestamps for transactions. Order in listtransactions is still maintained because that ordering is done separately from the timestamps.

Fixes #11703 and
fixes #6662

@BashCo
Copy link

BashCo commented Dec 26, 2017

fix-timesmart appears to fix the issue I experienced with incorrect transaction timestamps when importing watch-only addresses. After compiling, I used -rescan as well as -zapwallettxes, neither of which resolved the issue (on my end). After making a new wallet and reimporting with importmulti, the timestamps are correct.

@meshcollider
Copy link
Contributor

meshcollider commented Dec 26, 2017

Unsure on the reasoning behind this initial behaviour so can't ACK/NACK until Luke or someone else explains. But looks like src/wallet/test/wallet_tests.cpp needs updating too.

Note I don't think GitHub doesn't understand "Fixes X and Y" when it does it's auto-close, you probably have to write Fixes X, fixes Y.

@gmaxwell
Copy link
Contributor

gmaxwell commented Jan 8, 2018

@luke-jr

This will show accurate and correct timestamps while maintaining
proper transaction order in listtransactions.
@luke-jr
Copy link
Member

luke-jr commented Feb 26, 2018

The idea IIRC was simply to ensure timestamps move forward at least in ordinary circumstances.

@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 8, 2018

Needs rebase

@maflcko
Copy link
Member

maflcko commented Apr 19, 2019

There hasn't been much activity lately and the patch still needs rebase, so I am closing this for now. Please let me know when you want to continue working on this, so the pull request can be re-opened.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strange state (Timestamps wrong) after importing a priv key. rescanning uses incorrect date for old transactions

9 participants