[Qt] Warn if fallback fee has been used #11892
Conversation
promag
left a comment
promag
left a comment
There was a problem hiding this comment.
utACK 28a47e7. Some nits though.
src/qt/sendcoinsdialog.cpp
Outdated
There was a problem hiding this comment.
I would reorder the sentenses: 1, 2, 3 -> 3, 1, 2. Also, avoid you/your?
There was a problem hiding this comment.
I think the order is correct (cause, fix, possible issue).
src/wallet/wallet.h
Outdated
There was a problem hiding this comment.
fee_calc? This line already uses new convention. Same for others.
src/qt/walletmodel.h
Outdated
There was a problem hiding this comment.
I keep it non const for now to avoid changing code that receives that struct, also, other variables are also non-const.
src/qt/walletmodel.h
Outdated
There was a problem hiding this comment.
Drop _m_ prefix? , bool fallback_fee_used = false).
src/qt/walletmodel.cpp
Outdated
src/qt/walletmodel.cpp
Outdated
jonasschnelli
force-pushed
the
2017/12/qt_warn_fallbackfee
branch
from
28a47e7 to
147dc47
Compare
|
Fixed @promag points |
|
Concept ACK. |
|
Another option for the GUI would be to just prevent using a fallback fee at all. We already have the option to manually set the fee. We could instead refuse to send the transaction unless the user manually sets the fee. I think I would prefer that approach. Actually it might not be terrible to do a similar thing for RPC. Where any sendto call fails if fee estimation is needed and doesn't work with an error message telling you you must specify the fee (hopefully the option to specify the fee exists for all RPC sending calls). But at the very least we could do it for QT. |
|
@morcos see #11882.
|
|
@jonasschnelli commented there. EDIT. And I think the release notes and help could say that if you are setting a fallbackfee it is highly recommend, but not required that you set walletrbf=1, but adding two more config options seems overkill. |
|
Sure you're right |
|
"static fallback transaction fee" does not mean a lot to me (and most people). Can this be rephrased to something human readable? |
|
Is this still needed, since the user explicitly set the fallbackfee (and thus is aware of it)? I am assuming #11882. |
|
I think as long as a fallback fee is possible, a warning should appear in case such was used. |
|
[I don't want to block progress on any PRs but] I'd have to google this 'static fallback transaction fee' and doublecheck before i'd feel happy to make the transaction after reading such a warning.. |
|
@thijstriemstra Would it help to put the "Please consider waiting a few blocks until fee estimation is ready" first? |
|
In a way, but 'a few', can we be more specific? or less detailed? :) as long as cryptic statements like 'static fallback' are avoided I think. Thanks for the feedback! |
|
I think this can be closed now that the fallback fee has been disabled on mainnet (#11882). |
7 participants
This PR appends a warning at the send coins confirmation text in case the fallback fee was used.