-
Notifications
You must be signed in to change notification settings - Fork 38.8k
Remove unused include in hash.cpp #11884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused include in hash.cpp #11884
Conversation
|
Please don't mark this as trivial (it's changing the code being compiled), but otherwise obvious ACK. |
jonasschnelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK c1e5e27e7a612703f7351f8fc9ce47be669d93ca
You could argue that it doesn't, actually, but I'll keep that in mind. |
One way to find out for sure: compare executables with https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/build-for-compare.py. |
|
utACK c1e5e27e7a612703f7351f8fc9ce47be669d93ca |
c1e5e27 to
3f09e03
Compare
|
Removed "[trivial]" from commit message. |
|
utACK 3f09e03. |
|
Tend to NACK here, since a related pull was just merged: #10574 and I fail to see why this change wasn't included there. I'd rather avoid another upcoming wave of commits with little value compared to the review it has to go through. I am fine if you improve the travis check (#11878) instead. In case my NACK is invalid, binary diff: < 3554a6: mov $0x6b,%edx
---
> 3554a6: mov $0x6a,%edxutACK 3f09e03 |
|
@MarcoFalke I don't see why the other merge is related, and I don't think this commit has little value. Removing redundant/unused includes is quite beneficial in many cases. And one-liners are trivial to review. The duplicate includes PR you pointed to seems slightly unrelated. This isn't a duplicate include, this is an unused include. Nowhere in the |
|
@kallewoof Jup, you are right. |
3f09e03 Remove unused include in hash.cpp (Karl-Johan Alm) Pull request description: Tree-SHA512: 543a72656460fba1c5498a0b85c49601d9b0399a4ecc49f4acf4715c258918da729df388e3be724c3161438e903ee16ad3c50626a71483aa6d85ffdbb827742d
3f09e03 Remove unused include in hash.cpp (Karl-Johan Alm) Pull request description: Tree-SHA512: 543a72656460fba1c5498a0b85c49601d9b0399a4ecc49f4acf4715c258918da729df388e3be724c3161438e903ee16ad3c50626a71483aa6d85ffdbb827742d
No description provided.