Skip to content

Conversation

@kallewoof
Copy link
Contributor

No description provided.

@sipa
Copy link
Member

sipa commented Dec 13, 2017

Please don't mark this as trivial (it's changing the code being compiled), but otherwise obvious ACK.

@fanquake fanquake changed the title [trivial] Remove unused include in hash.cpp Remove unused include in hash.cpp Dec 13, 2017
Copy link
Contributor

@jonasschnelli jonasschnelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK c1e5e27e7a612703f7351f8fc9ce47be669d93ca

@kallewoof
Copy link
Contributor Author

Please don't mark this as trivial (it's changing the code being compiled), but otherwise obvious ACK.

You could argue that it doesn't, actually, but I'll keep that in mind.

@laanwj
Copy link
Member

laanwj commented Dec 13, 2017

You could argue that it doesn't, actually, but I'll keep that in mind.

One way to find out for sure: compare executables with https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/build-for-compare.py.
(though I don't think this argument is worth it, utACK anyhow, please update the commit message too)

@practicalswift
Copy link
Contributor

practicalswift commented Dec 13, 2017

utACK c1e5e27e7a612703f7351f8fc9ce47be669d93ca

@kallewoof kallewoof force-pushed the 20171213-unneeded-include-hash-cpp branch from c1e5e27 to 3f09e03 Compare December 13, 2017 11:09
@kallewoof
Copy link
Contributor Author

kallewoof commented Dec 13, 2017

Removed "[trivial]" from commit message.

@promag
Copy link
Contributor

promag commented Dec 13, 2017

utACK 3f09e03.

@maflcko
Copy link
Member

maflcko commented Dec 13, 2017

Tend to NACK here, since a related pull was just merged: #10574 and I fail to see why this change wasn't included there. I'd rather avoid another upcoming wave of commits with little value compared to the review it has to go through.

I am fine if you improve the travis check (#11878) instead.

In case my NACK is invalid, binary diff:

<   3554a6:	mov    $0x6b,%edx
---
>   3554a6:	mov    $0x6a,%edx

utACK 3f09e03

@kallewoof
Copy link
Contributor Author

@MarcoFalke I don't see why the other merge is related, and I don't think this commit has little value. Removing redundant/unused includes is quite beneficial in many cases. And one-liners are trivial to review.

The duplicate includes PR you pointed to seems slightly unrelated. This isn't a duplicate include, this is an unused include. Nowhere in the hash.cpp code does it use anything from pubkey.h. It may be possible to use static analysers to detect that sort of thing, but it smells like something that would give false positives occasionally.

@maflcko
Copy link
Member

maflcko commented Dec 14, 2017

@kallewoof Jup, you are right.

@laanwj laanwj merged commit 3f09e03 into bitcoin:master Dec 14, 2017
laanwj added a commit that referenced this pull request Dec 14, 2017
3f09e03 Remove unused include in hash.cpp (Karl-Johan Alm)

Pull request description:

Tree-SHA512: 543a72656460fba1c5498a0b85c49601d9b0399a4ecc49f4acf4715c258918da729df388e3be724c3161438e903ee16ad3c50626a71483aa6d85ffdbb827742d
@kallewoof kallewoof deleted the 20171213-unneeded-include-hash-cpp branch October 17, 2019 08:39
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Mar 24, 2020
3f09e03 Remove unused include in hash.cpp (Karl-Johan Alm)

Pull request description:

Tree-SHA512: 543a72656460fba1c5498a0b85c49601d9b0399a4ecc49f4acf4715c258918da729df388e3be724c3161438e903ee16ad3c50626a71483aa6d85ffdbb827742d
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants