[tests] Change invalidblockrequest to use BitcoinTestFramework #11772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2017
jnewbery
force-pushed
the
refactor_invalidblockrequest
branch
from
a61e0e4 to
3650eb4
Compare
Contributor
Author
|
This requires rebase, but I'll leave it as it is until #11771 is reviewed/merged. |
This was referenced Dec 2, 2017
jnewbery
force-pushed
the
refactor_invalidblockrequest
branch
from
3650eb4 to
62bb3a0
Compare
ryanofsky
reviewed
Dec 20, 2017
Contributor
ryanofsky
left a comment
ryanofsky
left a comment
There was a problem hiding this comment.
Reviewed last two commits only. Other commits are part of #11771 (and out of date).
- utACK 62bb3a0892558cf8813a22e1bf7860598dde3441 [tests] Change invalidblockrequest to use BitcoinTestFramework
- utACK 1d26a167c73b3e94509b3d39fa5875fdb9601eb1 [tests] Fix flake8 warnings in invalidblockrequest
Contributor
There was a problem hiding this comment.
In commit "Change invalidblockrequest to use BitcoinTestFramework"
Maybe avoid 0x prefix here and above by calling int(hash, 16)
Contributor
Author
|
This requires rebase now that #11771 has been merged. Review comments from @conscott to address in this PR:
|
Remove unused variable reassignments in p2p_invalid_tx.py and call send_txs_and_test() with valid transaction.
[tests] update tests from changes to mininode in bitcoin#11771 - added by @conscott [tests] trivial update to hex conversion for readability - added by @conscott
jnewbery
force-pushed
the
refactor_invalidblockrequest
branch
from
62bb3a0 to
e97b113
Compare
Contributor
Author
Contributor
|
👍 utACK e97b113 |
Member
|
utACK e97b113 |
maflcko
pushed a commit
that referenced
this pull request
Mar 13, 2018
…amework e97b113 [tests] Change invalidblockrequest to use BitcoinTestFramework (John Newbery) 2b7064e [tests] Fix flake8 warnings in invalidblockrequest (John Newbery) 54b8c58 [test] Fix nits leftover from 11771 (Conor Scott) Pull request description: Builds on #11771. Please review that PR first Next step in #10603. - first commit tidies up invalidblockrequest.py - second commit removes usage of ComparisonTestFramework Tree-SHA512: 14b10c09c8c0ebef4a9176eb5b883a275d04c096785ee31b84ef594eed346ec6344d7ed32184c5fb397e744725df3911f45cdfadd0810e5a52eaa256084e3456
Contributor
Author
Agree - this assert: should be removed in a future PR. |
maflcko
pushed a commit
that referenced
this pull request
Apr 5, 2018
…TestFramework] 9c92c8c [tests] Remove Comparison Test Framework (John Newbery) e80c640 [tests] Remove bip9-softforks.py (John Newbery) Pull request description: Builds on #11772, #11773 and #11817. Please review those PRs first. Final step in #10603. - First commit removes bip9-softforks.py. bip9-sofforks.py was intended to be a generic test for versionbits deployments. However, it only tests CSV activation and was not updated to test segwit activation. CSV activation is tested by bip68-112-113-p2p.py, so this test is duplicated effort. Rather than try to update it to use the BitcoinTestFramework, just remove it. (see btcdrak#8 for previous discussion around the redundancy of bip9-softforks.py) - Second commit removes the now unused BitcoinComparisonFramework class and the comptool and blockstore modules. Tree-SHA512: 4bb7196d521048b3b8ba95c87dde73005a1ac73d29ccbb869f11ce9a71089686e7eacd7335337853041dfbd3a5b110172b105adbada58779814d4db22b1376f5
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Oct 3, 2019
…nTestFramework e97b113 [tests] Change invalidblockrequest to use BitcoinTestFramework (John Newbery) 2b7064e [tests] Fix flake8 warnings in invalidblockrequest (John Newbery) 54b8c58 [test] Fix nits leftover from 11771 (Conor Scott) Pull request description: Builds on bitcoin#11771. Please review that PR first Next step in bitcoin#10603. - first commit tidies up invalidblockrequest.py - second commit removes usage of ComparisonTestFramework Tree-SHA512: 14b10c09c8c0ebef4a9176eb5b883a275d04c096785ee31b84ef594eed346ec6344d7ed32184c5fb397e744725df3911f45cdfadd0810e5a52eaa256084e3456
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #11771. Please review that PR first
Next step in #10603.