tests: move pwalletMain to wallet test fixture #11718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
force-pushed
the
2017_11_wallet_test_fixture
branch
from
45add22 to
088e551
Compare
Scope the variable instead of using an external global; this is how test fixtures are intended to be used. Followup to bitcoin#11713.
laanwj
force-pushed
the
2017_11_wallet_test_fixture
branch
from
088e551 to
49bd659
Compare
Contributor
|
utACK 49bd659 |
Member
|
utACK 49bd659 |
laanwj
added a commit
that referenced
this pull request
Nov 19, 2017
49bd659 tests: move pwalletMain to wallet test fixture (Wladimir J. van der Laan) Pull request description: Scope the variable instead of using an external global; this is how test fixtures are intended to be used. Followup to #11713. Tree-SHA512: 7d5bda93cdfe1329c8fe39bd72965906e36dad72fbb5d344ebedf26e66b1857510d01a3c2872d7f718fdeb23365e6ba71991aafe68e82781c6767a086b6d1590
Member
|
post merge utACK 49bd659 |
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Mar 24, 2020
49bd659 tests: move pwalletMain to wallet test fixture (Wladimir J. van der Laan) Pull request description: Scope the variable instead of using an external global; this is how test fixtures are intended to be used. Followup to bitcoin#11713. Tree-SHA512: 7d5bda93cdfe1329c8fe39bd72965906e36dad72fbb5d344ebedf26e66b1857510d01a3c2872d7f718fdeb23365e6ba71991aafe68e82781c6767a086b6d1590
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope the variable instead of using an external global; this is how test fixtures are intended to be used.
Followup to #11713.