leveldb: Add filename to corruption errors #11674
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a corruption happens, report the filename of the file where corruptions happens. This will aid in diagnosing database corruption issues. Adds a GetName() to all the environment file classes to make it possible to report a filename downstream.
laanwj
force-pushed
the
2017_11_leveldb_report_errors
branch
from
a737475 to
47bc05c
Compare
Contributor
|
Big concept ACK, from IRC messages |
Contributor
|
Nice! |
Contributor
|
Concept ACK |
Member
Author
|
I've merged this upstream, so this will come back to the bitcoin repository eventually, after the next tree update. Closing. |
Merged
sebrandon1
pushed a commit
to sebrandon1/bitcoin
that referenced
this pull request
Feb 22, 2018
835a21b Squashed 'src/leveldb/' changes from c521b3ac65..64052c76c5 (MarcoFalke) Pull request description: Pull in changes from bitcoin#11674 (comment). Merges cleanly into master and 0.16 branch. Tree-SHA512: 819c042c0dfac8dc3078fc182c1e22d4a85b343967475d3389be5b5b056361114d8c9892437cd1dc4b45808c27880c0e166e047afc2c2bd2bbc33e55336a8c33
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 13, 2019
Summary: Pull in changes from bitcoin/bitcoin#11674 (comment). Backport of Bitcoin Core PR12451 bitcoin/bitcoin#12451 Test Plan: ``` make check ``` Reviewers: Fabien, #bitcoin_abc, deadalnix, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D4004
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Dec 22, 2019
Summary: Pull in changes from bitcoin/bitcoin#11674 (comment). Backport of Bitcoin Core PR12451 bitcoin/bitcoin#12451 Test Plan: ``` make check ``` Reviewers: Fabien, #bitcoin_abc, deadalnix, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D4004
proteanx
pushed a commit
to devaultcrypto/devault
that referenced
this pull request
Dec 23, 2019
Summary: Pull in changes from bitcoin/bitcoin#11674 (comment). Backport of Bitcoin Core PR12451 bitcoin/bitcoin#12451 Test Plan: ``` make check ``` Reviewers: Fabien, #bitcoin_abc, deadalnix, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D4004
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(bitcoin-core/leveldb-subtree#15 should go in first, but filing it here for review/visibility/easy testing, do not merge)
When a leveldb corruption happens, report the filename of the file where corruptions happens.
This will aid in diagnosing database corruption issues.
Adds a GetName() to all the environment file classes to make it possible to report a filename downstream.
Example:
(travis is failing due to subtree merge, which is correct)