0.15: Backports #11647
Merged
0.15: Backports #11647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github-Pull: bitcoin#11590 Rebased-From: 720d9e8
This fixes "Wallet file not specified" errors when making batch wallet RPC calls with more than one wallet loaded. This issue was reported by NicolasDorier <[email protected]> bitcoin#11257 Request URI is not used for anything except multiwallet request dispatching, so this change has no other effects. Fixes bitcoin#11257 Github-Pull: bitcoin#11277 Rebased-From: edafc71
Change AuthServiceProxyWrapper.__getattr__ to only wrap proxied attributes, not real attributes. This way AuthServiceProxyWrapper can continue logging RPC calls without complicating other object usages, and special case handling for the .url property can be dropped. Github-Pull: bitcoin#11277 Rebased-From: e02007a
Split off AuthServiceProxy.get_request method to make it easier to batch RPC requests without duplicating code and remove leading underscore from _batch method. This does not change any existing behavior. Github-Pull: bitcoin#11277 Rebased-From: 9f67646
This fixes a bug in coverage logging that's been around since the logging was introduced. Github-Pull: bitcoin#11277 Rebased-From: 505530c
Without this change, batch RPC calls are not included in coverage logs. Github-Pull: bitcoin#11277 Rebased-From: 74182f2
Tests bug reported in bitcoin#11257 Github-Pull: bitcoin#11277 Rebased-From: 4526d21
This was referenced Nov 9, 2017
Github-Pull: bitcoin#11289 Rebased-From: a38bfbc
Github-Pull: bitcoin#11289 Rebased-From: c098c58
OpenRC changed their program binary names in 2014 (3 years ago), and using the old names has loud warnings now Github-Pull: bitcoin#11676 Rebased-From: 2f041f0
Member
|
utACK 7af2457 |
laanwj
added a commit
that referenced
this pull request
Dec 17, 2017
7af2457 contrib/init: Update openrc-run filename (Luke Dashjr) 3f1db56 Wrap dumpwallet warning and note scripts aren't dumped (MeshCollider) 42ea47d Add wallet backup text to import*, add* and dumpwallet RPCs (MeshCollider) 3a6cdd4 Add test for multiwallet batch RPC calls (Russell Yanofsky) 1c8c7f8 Add missing batch rpc calls to python coverage logs (Russell Yanofsky) 1036c43 Add missing multiwallet rpc calls to python coverage logs (Russell Yanofsky) 2eea279 Make AuthServiceProxy._batch method usable (Russell Yanofsky) 305f768 Limit AuthServiceProxyWrapper.__getattr__ wrapping (Russell Yanofsky) 7026845 Fix uninitialized URI in batch RPC requests (Russell Yanofsky) 6372a75 [Wallet] always show help-line of wallet encryption calls (Jonas Schnelli) Pull request description: This fixes some multiwallet issues on the 0.15 branch... Tree-SHA512: 304a6c6acbce22c8b7338d1e618451978ab2cd04938c71a3daf40fe9996ef14e324645d642fbc21950a5481fb993254082d54da1cb953a739ebaeaab34c080d4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some multiwallet issues on the 0.15 branch...