rpc: Make logging RPC public
#11626
Merged
rpc: Make logging RPC public
#11626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This started out as a developer hack but now it's useful enough for general use. Unhide the call by moving it to `control` category. This makes it documented in `help`.
Member
Contributor
|
utACK cabff75. |
Member
|
utACK cabff75 |
Contributor
|
ACK cabff75. I have no objection to making this unhidden. Could also be done as part of this PR, but not strictly necessary: the help text could be cleaned up. For example "libevent logging is configured on startup and cannot be modified by this RPC during runtime." is incorrect after 7fd50c3 (libevent logging can be updated for most versions of libevent). A few more newlines in the help text wouldn't hurt either. |
Contributor
|
Concept ACK |
maflcko
pushed a commit
that referenced
this pull request
Nov 7, 2017
cabff75 rpc: Make logging RPC public (Wladimir J. van der Laan) Pull request description: This started out as a developer hack but now it's useful enough for general use. Unhide the call by moving it to `control` category. This makes it documented in `help`. Tree-SHA512: f45fa378558b552d4e2a110bf85100b0eaaa6180bb5f62cb54a251f66026d4625b670c69d85c281eebbf4b56b80b65618c51a5a593b8f9d0a04b31e95adc91f4
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Nov 11, 2017
This started out as a developer hack but now it's useful enough for general use. Unhide the call by moving it to `control` category. This makes it documented in `help`. Github-Pull: bitcoin#11626 Rebased-From: cabff75
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 25, 2019
Summary: cabff75 rpc: Make logging RPC public (Wladimir J. van der Laan) Pull request description: This started out as a developer hack but now it's useful enough for general use. Unhide the call by moving it to `control` category. This makes it documented in `help`. Tree-SHA512: f45fa378558b552d4e2a110bf85100b0eaaa6180bb5f62cb54a251f66026d4625b670c69d85c281eebbf4b56b80b65618c51a5a593b8f9d0a04b31e95adc91f4 Backport of Core PR11626 bitcoin/bitcoin#11626 Depends on D3464 Test Plan: make check ./bitcoind ./bitcoin-cli help The `logging` rpc should appear under the `Control` section. Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Reviewed By: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D3684
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 16, 2020
cabff75 rpc: Make logging RPC public (Wladimir J. van der Laan) Pull request description: This started out as a developer hack but now it's useful enough for general use. Unhide the call by moving it to `control` category. This makes it documented in `help`. Tree-SHA512: f45fa378558b552d4e2a110bf85100b0eaaa6180bb5f62cb54a251f66026d4625b670c69d85c281eebbf4b56b80b65618c51a5a593b8f9d0a04b31e95adc91f4
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Oct 1, 2020
Summary: cabff7588 rpc: Make logging RPC public (Wladimir J. van der Laan) Pull request description: This started out as a developer hack but now it's useful enough for general use. Unhide the call by moving it to `control` category. This makes it documented in `help`. Tree-SHA512: f45fa378558b552d4e2a110bf85100b0eaaa6180bb5f62cb54a251f66026d4625b670c69d85c281eebbf4b56b80b65618c51a5a593b8f9d0a04b31e95adc91f4 Backport of Core PR11626 bitcoin/bitcoin#11626 Depends on D3464 Test Plan: make check ./bitcoind ./bitcoin-cli help The `logging` rpc should appear under the `Control` section. Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Reviewed By: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D3684
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Oct 5, 2020
Summary: cabff7588 rpc: Make logging RPC public (Wladimir J. van der Laan) Pull request description: This started out as a developer hack but now it's useful enough for general use. Unhide the call by moving it to `control` category. This makes it documented in `help`. Tree-SHA512: f45fa378558b552d4e2a110bf85100b0eaaa6180bb5f62cb54a251f66026d4625b670c69d85c281eebbf4b56b80b65618c51a5a593b8f9d0a04b31e95adc91f4 Backport of Core PR11626 bitcoin/bitcoin#11626 Depends on D3464 Test Plan: make check ./bitcoind ./bitcoin-cli help The `logging` rpc should appear under the `Control` section. Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Reviewed By: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D3684
jonspock
pushed a commit
to devaultcrypto/devault
that referenced
this pull request
Oct 10, 2020
Summary: cabff7588 rpc: Make logging RPC public (Wladimir J. van der Laan) Pull request description: This started out as a developer hack but now it's useful enough for general use. Unhide the call by moving it to `control` category. This makes it documented in `help`. Tree-SHA512: f45fa378558b552d4e2a110bf85100b0eaaa6180bb5f62cb54a251f66026d4625b670c69d85c281eebbf4b56b80b65618c51a5a593b8f9d0a04b31e95adc91f4 Backport of Core PR11626 bitcoin/bitcoin#11626 Depends on D3464 Test Plan: make check ./bitcoind ./bitcoin-cli help The `logging` rpc should appear under the `Control` section. Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Reviewed By: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D3684
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started out as a developer hack but now it's useful enough for general use. Unhide the call by moving it to
controlcategory. This makes it documented inhelp.