qa: Fix race condition failures in replace-by-fee.py, sendheaders.py #11538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdaftuar
changed the title
Member
Author
|
Example of the sendheaders failure is here: https://travis-ci.org/bitcoin/bitcoin/jobs/290599516 |
instagibbs
approved these changes
Oct 21, 2017
test/functional/replace-by-fee.py
Outdated
| def run_test(self): | ||
| # Leave IBD and ensure nodes are synced | ||
| self.nodes[0].generate(1) | ||
| self.sync_all() |
Member
There was a problem hiding this comment.
maybe stick the sync_call after the first make_utxo on line 79, just to be sure in the future?
Member
|
utACK eb0064be6f33c3d0015d84be38eee4f7256d943b |
Contributor
|
utACK eb0064be6f33c3d0015d84be38eee4f7256d943b |
sdaftuar
force-pushed
the
2017-10-fix-rbf-test
branch
from
eb0064b to
6d51eae
Compare
Contributor
|
tested ACK 6d51eae |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Oct 23, 2017
Github-Pull: bitcoin#11538 Rebased-From: c96b2e4
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Oct 23, 2017
Github-Pull: bitcoin#11538 Rebased-From: 6d51eae
maflcko
pushed a commit
that referenced
this pull request
Oct 23, 2017
…endheaders.py 6d51eae qa: Fix race condition in sendheaders.py (Suhas Daftuar) c96b2e4 qa: Fix replace-by-fee race condition failures (Suhas Daftuar) Pull request description: I think #11407 broke replace-by-fee by introducing a race condition. I was observing frequent failures of replace-by-fee locally, always with a mempool sync failure (the sync call was added in #11407). It appeared to me like there were two causes: sometimes the node would be in IBD and not request the transaction that was relayed; other times the blocks generated in make_utxo wouldn't have relayed quickly enough for the spend of the transaction to be accepted. I believe I've fixed both potential errors. ping @instagibbs Edit: I found a race condition in the sendheaders.py test, where if the verack from the python node wasn't processed before the first block in the test was generated, then no block announcement would go out to that peer, breaking the test. Fixed by adding a sync_with_ping after waiting for verack. Tree-SHA512: 6ad160966e432c151c1ce6e88ae67e60e47123523bda3755cf7697a00e1a5ba38de8561751826e3d7cf0e492f8c2aec298e1b4de8424ebbaf497f099a1ef1d07
Member
|
Backported in #11550 |
codablock
added a commit
to codablock/dash
that referenced
this pull request
Sep 30, 2019
To align with bitcoin#11538
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think #11407 broke replace-by-fee by introducing a race condition. I was observing frequent failures of replace-by-fee locally, always with a mempool sync failure (the sync call was added in #11407).
It appeared to me like there were two causes: sometimes the node would be in IBD and not request the transaction that was relayed; other times the blocks generated in make_utxo wouldn't have relayed quickly enough for the spend of the transaction to be accepted. I believe I've fixed both potential errors.
ping @instagibbs
Edit: I found a race condition in the sendheaders.py test, where if the verack from the python node wasn't processed before the first block in the test was generated, then no block announcement would go out to that peer, breaking the test. Fixed by adding a sync_with_ping after waiting for verack.