[trivial] [tests] A few Python3 tidy ups #11513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
utACK f893085 |
Contributor
|
Concept ACK - very nice cleanup! |
Contributor
|
utACK f893085 |
maflcko
pushed a commit
that referenced
this pull request
Oct 17, 2017
f893085 [tests] Don't subclass from object for Python 3 (John Newbery) 8f9e362 [tests] authproxy.py: tidy up __init__() (John Newbery) 323d8f6 [tests] fix flake8 warnings in authproxy.py (John Newbery) fc0176d [tests] use python3 for authproxy.py (John Newbery) Pull request description: A few trivial tidyups in the test_framework: - the test_framework can only be run in Python3, so remove the py2/3 compatibility workarounds in authproxy.py - while there, do some general tidying up of the module - fix flake8 warnings, make initialization code more compact - All classes in Python3 are new-style. No need to explicitly inherit from `object`. Tree-SHA512: d15c93aa4b47c1ad7d05baa7a564053cf0294932e178c95ef335380113f42e1af314978d07d3b107292a8e3496fd840535b5571a9164182feaa062a1e9ff8b73
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 29, 2020
f893085 [tests] Don't subclass from object for Python 3 (John Newbery) 8f9e362 [tests] authproxy.py: tidy up __init__() (John Newbery) 323d8f6 [tests] fix flake8 warnings in authproxy.py (John Newbery) fc0176d [tests] use python3 for authproxy.py (John Newbery) Pull request description: A few trivial tidyups in the test_framework: - the test_framework can only be run in Python3, so remove the py2/3 compatibility workarounds in authproxy.py - while there, do some general tidying up of the module - fix flake8 warnings, make initialization code more compact - All classes in Python3 are new-style. No need to explicitly inherit from `object`. Tree-SHA512: d15c93aa4b47c1ad7d05baa7a564053cf0294932e178c95ef335380113f42e1af314978d07d3b107292a8e3496fd840535b5571a9164182feaa062a1e9ff8b73 fix up mininode.py slightly Signed-off-by: Pasta <[email protected]>
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Jun 30, 2021
f893085 [tests] Don't subclass from object for Python 3 (John Newbery) 8f9e362 [tests] authproxy.py: tidy up __init__() (John Newbery) 323d8f6 [tests] fix flake8 warnings in authproxy.py (John Newbery) fc0176d [tests] use python3 for authproxy.py (John Newbery) Pull request description: A few trivial tidyups in the test_framework: - the test_framework can only be run in Python3, so remove the py2/3 compatibility workarounds in authproxy.py - while there, do some general tidying up of the module - fix flake8 warnings, make initialization code more compact - All classes in Python3 are new-style. No need to explicitly inherit from `object`. Tree-SHA512: d15c93aa4b47c1ad7d05baa7a564053cf0294932e178c95ef335380113f42e1af314978d07d3b107292a8e3496fd840535b5571a9164182feaa062a1e9ff8b73 fix up mininode.py slightly Signed-off-by: Pasta <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few trivial tidyups in the test_framework:
object.