rpc: Update named args documentation for importprivkey #11465
Conversation
|
IMO remove 2nd commit. |
|
@promag It nicely proves that the documentation now matches the named args |
|
The first commit does what the PR title states. No need to change the test to use named arguments. This is obviously my opinion! |
|
No, the test does not prove that, to prove that we should assert the documentation string. Again consider my comment above a nit. |
|
There must be a test to assert argument order too :) (although that is probably in other tests). |
|
@MarcoFalke @promag I can remove the second commit if you'd prefer! Is there a neat way to do that through github or do I need to re-commit with the changes? |
|
For reference, this was missed in #8811 (9adb4e1). @dusty-wil to remove the commit you must push again. But do not remove it now, wait for more comments. |
|
I think squashing makes the most sense. See here: https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits |
Fixes bitcoin#11462. Updated documentation for importprivkey function to use the correct name for the first argument. Also updates a call to importprivkey to use named args in functional test.
|
@MarcoFalke ok, squashed! |
|
utACK aa57590 |
|
utACK aa57590 |
1 similar comment
|
utACK aa57590 |
aa57590 Update importprivkey named args documentation (Dusty Williams) Pull request description: Addresses issue #11462 by updating the documentation for the importprivkey arguments to the correct names, and updates the functional test importprunedfunds.py to use named arguments when calling importprivkey. Tree-SHA512: 64e14bf89c8c6eec9c37f6ec0c9fc0012fdb035d9ec32cd652110c75abaa922ec5c7523d6ec5098c8a7b42124159b5e330e070974eb79b8b92816f8d61074523
|
Thanks for the opportunity to contribute! |
Fixes bitcoin#11462. Updated documentation for importprivkey function to use the correct name for the first argument. Also updates a call to importprivkey to use named args in functional test. Github-Pull: bitcoin#11465 Rebased-From: aa57590
…rivkey aa57590 Update importprivkey named args documentation (Dusty Williams) Pull request description: Addresses issue bitcoin#11462 by updating the documentation for the importprivkey arguments to the correct names, and updates the functional test importprunedfunds.py to use named arguments when calling importprivkey. Tree-SHA512: 64e14bf89c8c6eec9c37f6ec0c9fc0012fdb035d9ec32cd652110c75abaa922ec5c7523d6ec5098c8a7b42124159b5e330e070974eb79b8b92816f8d61074523
5 participants
Addresses issue #11462 by updating the documentation for the importprivkey arguments to the correct names, and updates the functional test importprunedfunds.py to use named arguments when calling importprivkey.