net: Improve and document SOCKS code #11397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
force-pushed
the
2017_09_socks_refactor
branch
from
eccca31 to
0f92fb2
Compare
promag
reviewed
Sep 25, 2017
src/netbase.cpp
Outdated
Contributor
There was a problem hiding this comment.
Funny, in windows 2nd arg is char*, that's why the build failed.
Member
Author
There was a problem hiding this comment.
Oops, thought it would be void, added the wrong cast. Should be ok now.
laanwj
force-pushed
the
2017_09_socks_refactor
branch
from
0f92fb2 to
46544c6
Compare
Member
|
utACK 46544c60d67d8a7095e7243795d2b570ab8391e3. InterruptibleRecv goes away soon as part of the async connection work, but having the SOCKS constants defined will make those changes much easier to review. Thanks for saving me a step :) |
Contributor
|
utACK 46544c6. |
promag
reviewed
Sep 25, 2017
src/netbase.cpp
Outdated
Contributor
There was a problem hiding this comment.
Nit, align this and above comments with below.
Make the SOCKS code more consistent, and document the constants used.
Member
Author
laanwj
force-pushed
the
2017_09_socks_refactor
branch
from
46544c6 to
22f816e
Compare
Member
|
utACK 22f816e |
Contributor
|
Tested ACK (macOS 10.12) 22f816e. |
jonasschnelli
added a commit
that referenced
this pull request
Sep 28, 2017
22f816e net: Improve and document SOCKS code (Wladimir J. van der Laan) Pull request description: Make the SOCKS code more consistent, and document the constants used. Tree-SHA512: 1bb04fcd6aacb6bfd2c54989d8298c892036466a895efb88be36fbace041af67c964ae0f5fb76c96f813f20a040109de4e0aac49a20844640e4d7633fcb22f25
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Oct 9, 2017
Make the SOCKS code more consistent, and document the constants used. Github-Pull: bitcoin#11397 Rebased-From: 22f816e
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Sep 25, 2019
22f816e net: Improve and document SOCKS code (Wladimir J. van der Laan) Pull request description: Make the SOCKS code more consistent, and document the constants used. Tree-SHA512: 1bb04fcd6aacb6bfd2c54989d8298c892036466a895efb88be36fbace041af67c964ae0f5fb76c96f813f20a040109de4e0aac49a20844640e4d7633fcb22f25
ebfull
added a commit
to ebfull/zcash
that referenced
this pull request
Nov 8, 2019
Adapted from bitcoin/bitcoin#11397 by Wladimir J. van der Laan. Co-Authored-By: Jack Grigg <[email protected]> Co-Authored-By: Daira Hopwood <[email protected]>
cronicc
pushed a commit
to HorizenOfficial/zen
that referenced
this pull request
Nov 8, 2019
Adapted from bitcoin/bitcoin#11397 by Wladimir J. van der Laan. Co-Authored-By: Jack Grigg <[email protected]> Co-Authored-By: Daira Hopwood <[email protected]>
milesmanley
pushed a commit
to milesmanley/zel
that referenced
this pull request
Nov 8, 2019
Adapted from bitcoin/bitcoin#11397 by Wladimir J. van der Laan. Co-Authored-By: Jack Grigg <[email protected]> Co-Authored-By: Daira Hopwood <[email protected]>
ca333
added a commit
to GLEECBTC/komodo-daemon
that referenced
this pull request
Nov 9, 2019
denverbdr
pushed a commit
to ycashfoundation/ycash
that referenced
this pull request
Nov 9, 2019
Adapted from bitcoin/bitcoin#11397 by Wladimir J. van der Laan. Co-Authored-By: Jack Grigg <[email protected]> Co-Authored-By: Daira Hopwood <[email protected]>
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Nov 19, 2019
22f816e net: Improve and document SOCKS code (Wladimir J. van der Laan) Pull request description: Make the SOCKS code more consistent, and document the constants used. Tree-SHA512: 1bb04fcd6aacb6bfd2c54989d8298c892036466a895efb88be36fbace041af67c964ae0f5fb76c96f813f20a040109de4e0aac49a20844640e4d7633fcb22f25
milesmanley
pushed a commit
to milesmanley/zel
that referenced
this pull request
Nov 23, 2019
Adapted from bitcoin/bitcoin#11397 by Wladimir J. van der Laan. Co-Authored-By: Jack Grigg <[email protected]> Co-Authored-By: Daira Hopwood <[email protected]>
MIPPL
pushed a commit
to biblepay/biblepay
that referenced
this pull request
Nov 24, 2019
* commit '8b14adb206d76fbc6307385999a1c512052e93fa': (21 commits) [v0.14.0.x] Update release notes with change log (dashpay#3213) [v0.14.0.x] Bump version to 0.14.0.4 and draft release notes (dashpay#3203) Circumvent BIP69 sorting in fundrawtransaction.py test (dashpay#3100) Fix compile issues Merge bitcoin#11397: net: Improve and document SOCKS code Slightly optimize ApproximateBestSubset and its usage for PS txes (dashpay#3184) Update activemn if protx info changed (dashpay#3176) Actually update spent index on DisconnectBlock (dashpay#3167) Only track last seen time instead of first and last seen time (dashpay#3165) Merge bitcoin#17118: build: depends macOS: point --sysroot to SDK (dashpay#3161) Simulate BlockConnected/BlockDisconnected for PS caches Few fixes related to SelectCoinsGroupedByAddresses (dashpay#3144) Various fixes for mixing queues (dashpay#3138) Also consider txindex for transactions in AlreadyHave() (dashpay#3126) Ignore recent rejects filter for locked txes (dashpay#3124) Make orphan TX map limiting dependent on total TX size instead of TX count (dashpay#3121) Update/modernize macOS plist (dashpay#3074) Fix bip69 vs change position issue (dashpay#3063) Partially revert 3061 (dashpay#3150) Fix SelectCoinsMinConf to allow instant respends (dashpay#3061) ... # Conflicts: # configure.ac # doc/man/biblepay-cli.1 # doc/man/biblepay-qt.1 # doc/man/biblepay-tx.1 # doc/man/biblepayd.1 # doc/release-notes.md # src/clientversion.h # src/wallet/wallet.cpp
Asherda
pushed a commit
to Asherda/VerusCoin
that referenced
this pull request
Nov 30, 2019
Adapted from bitcoin/bitcoin#11397 by Wladimir J. van der Laan. Co-Authored-By: Jack Grigg <[email protected]> Co-Authored-By: Daira Hopwood <[email protected]>
CryptoForge
pushed a commit
to CryptoForge/Zero
that referenced
this pull request
Dec 3, 2019
Adapted from bitcoin/bitcoin#11397 by Wladimir J. van der Laan. Co-Authored-By: Jack Grigg <[email protected]> Co-Authored-By: Daira Hopwood <[email protected]>
cryptobubbles
pushed a commit
to cryptoprofutonium/zclassic-1
that referenced
this pull request
Dec 7, 2019
Adapted from bitcoin/bitcoin#11397 by Wladimir J. van der Laan. Co-Authored-By: Jack Grigg <[email protected]> Co-Authored-By: Daira Hopwood <[email protected]>
hTrap
pushed a commit
to ZclassicCommunity/zclassic
that referenced
this pull request
Dec 8, 2019
* Disable -shrinkdebugfile command * Fix of CVE-2017-18350 Adapted from bitcoin/bitcoin#11397 by Wladimir J. van der Laan. Co-Authored-By: Jack Grigg <[email protected]> Co-Authored-By: Daira Hopwood <[email protected]> * Versioning changes for 2.0.6 Signed-off-by: cryptobubbles <[email protected]> * Updated manpages for 2.0.6 Signed-off-by: cryptobubbles <[email protected]> * Updated release notes for 2.0.6 Signed-off-by: cryptobubbles <[email protected]>
cryptobubbles
pushed a commit
to cryptoprofutonium/zclassic-patched-for-explorer
that referenced
this pull request
Dec 8, 2019
* Disable -shrinkdebugfile command * Fix of CVE-2017-18350 Adapted from bitcoin/bitcoin#11397 by Wladimir J. van der Laan. Co-Authored-By: Jack Grigg <[email protected]> Co-Authored-By: Daira Hopwood <[email protected]> * Versioning changes for 2.0.6 Signed-off-by: cryptobubbles <[email protected]> * Updated manpages for 2.0.6 Signed-off-by: cryptobubbles <[email protected]> * Updated release notes for 2.0.6 Signed-off-by: cryptobubbles <[email protected]>
cryptoprofutonium
added a commit
to ZclassicCommunity/zclassic-patched-for-explorer
that referenced
this pull request
Dec 8, 2019
* Disable -shrinkdebugfile command * Fix of CVE-2017-18350 Adapted from bitcoin/bitcoin#11397 by Wladimir J. van der Laan. Co-Authored-By: Jack Grigg <[email protected]> Co-Authored-By: Daira Hopwood <[email protected]> * Versioning changes for 2.0.6 Signed-off-by: cryptobubbles <[email protected]> * Updated manpages for 2.0.6 Signed-off-by: cryptobubbles <[email protected]> * Updated release notes for 2.0.6 Signed-off-by: cryptobubbles <[email protected]>
cryptoprofutonium
added a commit
to ZclassicCommunity/zclassic-patched-for-explorer
that referenced
this pull request
Dec 8, 2019
* Disable -shrinkdebugfile command * Fix of CVE-2017-18350 Adapted from bitcoin/bitcoin#11397 by Wladimir J. van der Laan. Co-Authored-By: Jack Grigg <[email protected]> Co-Authored-By: Daira Hopwood <[email protected]> * Versioning changes for 2.0.6 Signed-off-by: cryptobubbles <[email protected]> * Updated manpages for 2.0.6 Signed-off-by: cryptobubbles <[email protected]> * Updated release notes for 2.0.6 Signed-off-by: cryptobubbles <[email protected]>
cryptobubbles
pushed a commit
to cryptoprofutonium/zclassic-patched-for-explorer
that referenced
this pull request
Dec 8, 2019
* Disable -shrinkdebugfile command * Fix of CVE-2017-18350 Adapted from bitcoin/bitcoin#11397 by Wladimir J. van der Laan. Co-Authored-By: Jack Grigg <[email protected]> Co-Authored-By: Daira Hopwood <[email protected]> * Versioning changes for 2.0.6 Signed-off-by: cryptobubbles <[email protected]> * Updated manpages for 2.0.6 Signed-off-by: cryptobubbles <[email protected]> * Updated release notes for 2.0.6 Signed-off-by: cryptobubbles <[email protected]>
hTrap
pushed a commit
to ZclassicCommunity/zclassic-patched-for-explorer
that referenced
this pull request
Dec 8, 2019
* Disable -shrinkdebugfile command * Fix of CVE-2017-18350 Adapted from bitcoin/bitcoin#11397 by Wladimir J. van der Laan. Co-Authored-By: Jack Grigg <[email protected]> Co-Authored-By: Daira Hopwood <[email protected]> * Versioning changes for 2.0.6 Signed-off-by: cryptobubbles <[email protected]> * Updated manpages for 2.0.6 Signed-off-by: cryptobubbles <[email protected]> * Updated release notes for 2.0.6 Signed-off-by: cryptobubbles <[email protected]>
cronicc
pushed a commit
to HorizenOfficial/zen
that referenced
this pull request
Feb 10, 2020
Adapted from bitcoin/bitcoin#11397 by Wladimir J. van der Laan. Co-Authored-By: Jack Grigg <[email protected]> Co-Authored-By: Daira Hopwood <[email protected]>
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Feb 1, 2021
31b0fbd net: Improve and document SOCKS code (Wladimir J. van der Laan) Pull request description: cherry-picked from bitcoin#11397. > Make the SOCKS code more consistent, and document the constants used. ACKs for top commit: furszy: ACK 31b0fbd Fuzzbawls: ACK 31b0fbd Tree-SHA512: 5b899667f103568bd48728789d5d3b688f10c13466e45e34ecaf6ca0651f27d7be880ddae80bd206af1fd3b01ca963c016260ec1a26cb89107c52870b8dd3fda
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the SOCKS code more consistent, and document the constants used.