Skip to content

Conversation

@TheBlueMatt
Copy link
Contributor

Does what it says on the tin.

@instagibbs
Copy link
Member

utACK 53525ee

@TheBlueMatt TheBlueMatt force-pushed the 2017-09-bitcoin-tx-uncompressed-segwit branch from 53525ee to 7c8b452 Compare September 21, 2017 02:16
@meshcollider
Copy link
Contributor

utACK 7c8b452

Should the capitalization be 'SegWit' though, not 'Segwit'? Or all lowercase instead?

@TheBlueMatt TheBlueMatt force-pushed the 2017-09-bitcoin-tx-uncompressed-segwit branch from 7c8b452 to 28d4542 Compare September 21, 2017 03:30
@TheBlueMatt
Copy link
Contributor Author

Changed to "SegWit", didn't realize there was a "correct" capitalization.

@jonasschnelli
Copy link
Contributor

Nice catch!
utACK 28d4542

@jl2012
Copy link
Contributor

jl2012 commented Sep 25, 2017

utACK 28d4542
need backport?

@sipa
Copy link
Member

sipa commented Sep 25, 2017

utACK 28d4542. I didn't know this was supported in bitcoin-tx.

Copy link
Contributor

@gmaxwell gmaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@gmaxwell
Copy link
Contributor

gmaxwell commented Sep 25, 2017

Needs backport tag please. This should be 0.15.1 milestone.

@fanquake fanquake added this to the 0.15.1 milestone Sep 26, 2017
@laanwj laanwj merged commit 28d4542 into bitcoin:master Sep 26, 2017
laanwj added a commit that referenced this pull request Sep 26, 2017
…output adds

28d4542 Disallow uncompressed pubkeys in bitcoin-tx [multisig] output adds (Matt Corallo)

Pull request description:

  Does what it says on the tin.

Tree-SHA512: 324b8da8a9f9a35d3ade74f6c587f981894a085dfea9d64f78de745d5e6ec05c3a7bced487e9aad9c8a48151cd14969a0806f30f80b621edfce0da082fe6f4be
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Oct 3, 2017
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants