qt: Remove custom fee radio group and remove nCustomFeeRadio setting #11334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please rebase. |
Removes the extraneous custom fee radio group and its single radio button. The radio button is replaced with a label that has the radio button's text.
achow101
force-pushed
the
rm-nCustomFeeRadio
branch
from
323618b to
e53fa4a
Compare
Member
Author
|
Rebased |
Contributor
|
Concept ACK. Looks like travis failure was unrelated (some failure in p2p-versionbits-warning.py). |
Contributor
|
Concept ACK |
1 similar comment
Member
|
Concept ACK |
maflcko
changed the title
Member
|
utACK e53fa4a |
laanwj
added a commit
that referenced
this pull request
Sep 20, 2017
…Radio setting e53fa4a Remove custom fee radio group (Andrew Chow) Pull request description: Removes the extraneous custom fee radio group and its single radio button. The radio button is replaced with a label that has the radio button's text. Continuation of #11332 Tree-SHA512: b47b675f900ee4e2f4823203a42bb697f707ba67a8504d730c53d4dae511d0ed03226af34efd7ea45570c6111f8b3b6c39ac28f1b5c090de225903442ad4159a
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Oct 3, 2017
Removes the extraneous custom fee radio group and its single radio button. The radio button is replaced with a label that has the radio button's text. Github-Pull: bitcoin#11334 Rebased-From: e53fa4a
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Sep 23, 2019
…stomFeeRadio setting e53fa4a Remove custom fee radio group (Andrew Chow) Pull request description: Removes the extraneous custom fee radio group and its single radio button. The radio button is replaced with a label that has the radio button's text. Continuation of bitcoin#11332 Tree-SHA512: b47b675f900ee4e2f4823203a42bb697f707ba67a8504d730c53d4dae511d0ed03226af34efd7ea45570c6111f8b3b6c39ac28f1b5c090de225903442ad4159a
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 29, 2020
Summary: > Removes the extraneous custom fee radio group and its single radio > button. The radio button is replaced with a label that has the > radio button's text. This is a backport of Core [[bitcoin/bitcoin#11334 | PR11334]] Test Plan: `ninja && src/qt/bitcoin-qt` On send tab, select custom fee, verify that that "per kilobyte" is now a label instead of being a radio-button. Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D8177
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the extraneous custom fee radio group and its single radio button. The radio button is replaced with a label that has the radio button's text.
Continuation of #11332