-
Notifications
You must be signed in to change notification settings - Fork 38.7k
Put back inadvertently removed copyright notices #11318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In an abundance of caution this restores "Bitcoin Developers" to the COPYING file in case there were contributors before that point in time that would object to the current label. It's harmless and more pedantically correct. [Change extracted from the Bitcoin-abc repository, commit message by gmaxwell] Signed-off-by: Gregory Maxwell <[email protected]>
|
FWIW, I contributed under the original listing. I did not like the project rename and I personally have a general preference for the original attribution. |
|
The original Bitcoin software released by Satoshi included Satoshi Nakamoto in the license.txt and source code files. Should this be restored too? Further, it is my understanding that copyright notices should be applied to every file - should all file headers be updated with the correct copyright notices? |
|
@chriswheeler is there any reason WHY BTC should have changed such fundamentals in the first place? |
|
@chriswheeler @awitherow I believe Satoshi himself changed the text to Bitcoin Developers while the code was hosted on sourceforge: https://sourceforge.net/p/bitcoin/code/201/ |
|
I have just read the related discussion here: Bitcoin-ABC/bitcoin-abc#89 It does appear (thanks @meshcollider) that Satoshi changed the notice to "Bitcoin Developers". I still believe that this change should be made to all files, not just the COPYING file. |
|
ACK |
He changed it to the text my change includes himself. |
|
@chriswheeler Which other files are wrong? This mistake was introduced 3b00e7c, so it seems like a sole instance. |
|
Why is it possible to copyright this to the Bitcoin developers in general? Is there an actual copyright? Why has Satoshi been removed in general because it was his original creation? |
|
@awitherow as I and others pointed out above, Satoshi changed it himself |
|
It just was not clear to me due to insufficient grammar. Thank you for the clarification @meshcollider . Still doesn't answer the question if there is an actual copyright existing. |
|
@awitherow what do you mean by an "actual copyright"? Yes, the code is licensed under the MIT License and copyright to the bitcoin developers / core developers, as stated in https://github.com/bitcoin/bitcoin/blob/master/COPYING |
We could rename the project back, but I don't think it's worth the hassle. |
I think he means the copyright in individual source files, one could re-add the |
I agree. In any case, I agree with the suggestion that the headers get updated everywhere. But I don't see a problem with making that another PR. I'd prefer to do a change that touches every file later in the development cycle when we're not backporting everything to 0.15.x still. (unless someone argues otherwise). I'd prefer to not delay an improvement everyone agrees with (I think?) while waiting on a change that is going to touch 300 files. This change can also just apply to the 0.15 branch, not so much for a all-files toucher. Keep in mind, no copyright holder has ever complained here (beyond, I suppose, my comment above that I also prefer the change... and it's not like I really matter.) so this is lower urgency. |
|
@awitherow Whenever someone writes code, it is automatically copyrighted by them, and remains so until they assign it to someone else. There is no "Bitcoin developers" or "Bitcoin Core developers" legal entity - these are just English phrases that mean each contributor retains copyright to his own work. It's redundant, but harmless, to have both lines present, since they mean the same thing. |
|
ping |
|
ACK. |
Yeah - it was intended to create a distinction between bitcoin the currency, and the node software, as that was confusing people at the time. Of course, it is misinterpreted in the most horrible and creative ways. |
d552ed6 Put back inadvertently removed copyright notices (Paul Berg) Pull request description: In an abundance of caution this restores "Bitcoin Developers" to the COPYING file in case there were contributors before that point in time that would object to the current label. It's harmless and more pedantically correct. (Change extracted from the Bitcoin-abc github) Tree-SHA512: ea71645fbca5548bcae750b9bb7c7cc56791d8c8d2574b778fa1666e09abad23b30fcb434f0d92c52a2eb7d7e89caa32695dff3a5a99a2ab43ed0f3636436677
|
One final thought on this - If it's reverted, isn't that violating the rights of the people who contributed under the 'Bitcoin Core Developers' notice? I'm not a copyright lawyer, but I would advise getting some advice from someone who is before making changes to copyright notices without the consent of everyone who contributed. |
|
@chriswheeler the "Bitcoin Core developers" notice was not removed. A "The Bitcoin Developers" notice was added |
|
Oops. I should learn to read the diff better :) Sorry all. |
In an abundance of caution this restores "Bitcoin Developers" to the COPYING file in case there were contributors before that point in time that would object to the current label. It's harmless and more pedantically correct. [Change extracted from the Bitcoin-abc repository, commit message by gmaxwell] Signed-off-by: Gregory Maxwell <[email protected]> Github-Pull: bitcoin#11318 Rebased-From: d552ed6
d552ed6 Put back inadvertently removed copyright notices (Paul Berg) Pull request description: In an abundance of caution this restores "Bitcoin Developers" to the COPYING file in case there were contributors before that point in time that would object to the current label. It's harmless and more pedantically correct. (Change extracted from the Bitcoin-abc github) Tree-SHA512: ea71645fbca5548bcae750b9bb7c7cc56791d8c8d2574b778fa1666e09abad23b30fcb434f0d92c52a2eb7d7e89caa32695dff3a5a99a2ab43ed0f3636436677
In an abundance of caution this restores "Bitcoin Developers" to the COPYING file in
case there were contributors before that point in time that would object to the
current label. It's harmless and more pedantically correct.
(Change extracted from the Bitcoin-abc github)