Skip to content

Conversation

@gmaxwell
Copy link
Contributor

@gmaxwell gmaxwell commented Sep 13, 2017

In an abundance of caution this restores "Bitcoin Developers" to the COPYING file in
case there were contributors before that point in time that would object to the
current label. It's harmless and more pedantically correct.

(Change extracted from the Bitcoin-abc github)

In an abundance of caution this restores "Bitcoin Developers" to the COPYING file in
case there were contributors before that point in time that would object to the
current label.  It's harmless and more pedantically correct.

[Change extracted from the Bitcoin-abc repository, commit message by gmaxwell]

Signed-off-by: Gregory Maxwell <[email protected]>
@fanquake fanquake added the Docs label Sep 13, 2017
@gmaxwell
Copy link
Contributor Author

FWIW, I contributed under the original listing. I did not like the project rename and I personally have a general preference for the original attribution.

@chriswheeler
Copy link
Contributor

chriswheeler commented Sep 13, 2017

The original Bitcoin software released by Satoshi included Satoshi Nakamoto in the license.txt and source code files.

e.g. https://github.com/trottier/original-bitcoin/blob/master/license.txt

Should this be restored too?

Further, it is my understanding that copyright notices should be applied to every file - should all file headers be updated with the correct copyright notices?

@awitherow
Copy link

@chriswheeler is there any reason WHY BTC should have changed such fundamentals in the first place?

@meshcollider
Copy link
Contributor

@chriswheeler @awitherow I believe Satoshi himself changed the text to Bitcoin Developers while the code was hosted on sourceforge: https://sourceforge.net/p/bitcoin/code/201/

@chriswheeler
Copy link
Contributor

I have just read the related discussion here: Bitcoin-ABC/bitcoin-abc#89

It does appear (thanks @meshcollider) that Satoshi changed the notice to "Bitcoin Developers".

I still believe that this change should be made to all files, not just the COPYING file.

@Leviathn
Copy link

ACK

@gmaxwell
Copy link
Contributor Author

The original Bitcoin software released by Satoshi included Satoshi Nakamoto in the license.txt and source code files.

He changed it to the text my change includes himself.

@sipa
Copy link
Member

sipa commented Sep 13, 2017

@chriswheeler Which other files are wrong? This mistake was introduced 3b00e7c, so it seems like a sole instance.

@awitherow
Copy link

Why is it possible to copyright this to the Bitcoin developers in general?

Is there an actual copyright?

Why has Satoshi been removed in general because it was his original creation?

@meshcollider
Copy link
Contributor

@awitherow as I and others pointed out above, Satoshi changed it himself

@awitherow
Copy link

It just was not clear to me due to insufficient grammar. Thank you for the clarification @meshcollider .

Still doesn't answer the question if there is an actual copyright existing.

@meshcollider
Copy link
Contributor

@awitherow what do you mean by an "actual copyright"? Yes, the code is licensed under the MIT License and copyright to the bitcoin developers / core developers, as stated in https://github.com/bitcoin/bitcoin/blob/master/COPYING

@laanwj
Copy link
Member

laanwj commented Sep 14, 2017

FWIW, I contributed under the original listing. I did not like the project rename and I personally have a general preference for the original attribution.

We could rename the project back, but I don't think it's worth the hassle.
ACK anyhow.

@laanwj
Copy link
Member

laanwj commented Sep 14, 2017

@chriswheeler Which other files are wrong? This mistake was introduced 3b00e7c, so it seems like a sole instance.

I think he means the copyright in individual source files, one could re-add the (C) Bitcoin developers there too, for the files that existed before the rename or with code moved from files that existed before the rename (with the respective date range of before the project rename). Would be quite a lot of work tho.

@gmaxwell
Copy link
Contributor Author

gmaxwell commented Sep 15, 2017

We could rename the project back, but I don't think it's worth the hassle.

I agree. In any case, I agree with the suggestion that the headers get updated everywhere. But I don't see a problem with making that another PR. I'd prefer to do a change that touches every file later in the development cycle when we're not backporting everything to 0.15.x still. (unless someone argues otherwise).

I'd prefer to not delay an improvement everyone agrees with (I think?) while waiting on a change that is going to touch 300 files. This change can also just apply to the 0.15 branch, not so much for a all-files toucher.

Keep in mind, no copyright holder has ever complained here (beyond, I suppose, my comment above that I also prefer the change... and it's not like I really matter.) so this is lower urgency.

@luke-jr
Copy link
Member

luke-jr commented Sep 16, 2017

@awitherow Whenever someone writes code, it is automatically copyrighted by them, and remains so until they assign it to someone else. There is no "Bitcoin developers" or "Bitcoin Core developers" legal entity - these are just English phrases that mean each contributor retains copyright to his own work.

It's redundant, but harmless, to have both lines present, since they mean the same thing.

@gmaxwell
Copy link
Contributor Author

ping

@jonasschnelli
Copy link
Contributor

ACK.
The "Core" suffix may sound nice, but it suddenly created a gap between Bitcoin developers and "Bitcoin Core" developers where some people think the later is an organisation (which is obviously not true).

@laanwj
Copy link
Member

laanwj commented Sep 28, 2017

The "Core" suffix may sound nice, but it suddenly created a gap between Bitcoin developers and "Bitcoin Core" developers where some people think the later is an organisation (which is obviously not true).

Yeah - it was intended to create a distinction between bitcoin the currency, and the node software, as that was confusing people at the time. Of course, it is misinterpreted in the most horrible and creative ways.

@laanwj laanwj merged commit d552ed6 into bitcoin:master Sep 28, 2017
laanwj added a commit that referenced this pull request Sep 28, 2017
d552ed6 Put back inadvertently removed copyright notices (Paul Berg)

Pull request description:

  In an abundance of caution this restores "Bitcoin Developers" to the COPYING file in
  case there were contributors before that point in time that would object to the
  current label.  It's harmless and more pedantically correct.

  (Change extracted from the Bitcoin-abc github)

Tree-SHA512: ea71645fbca5548bcae750b9bb7c7cc56791d8c8d2574b778fa1666e09abad23b30fcb434f0d92c52a2eb7d7e89caa32695dff3a5a99a2ab43ed0f3636436677
@chriswheeler
Copy link
Contributor

One final thought on this - If it's reverted, isn't that violating the rights of the people who contributed under the 'Bitcoin Core Developers' notice? I'm not a copyright lawyer, but I would advise getting some advice from someone who is before making changes to copyright notices without the consent of everyone who contributed.

@achow101
Copy link
Member

@chriswheeler the "Bitcoin Core developers" notice was not removed. A "The Bitcoin Developers" notice was added

@chriswheeler
Copy link
Contributor

Oops. I should learn to read the diff better :) Sorry all.

maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Oct 3, 2017
In an abundance of caution this restores "Bitcoin Developers" to the COPYING file in
case there were contributors before that point in time that would object to the
current label.  It's harmless and more pedantically correct.

[Change extracted from the Bitcoin-abc repository, commit message by gmaxwell]

Signed-off-by: Gregory Maxwell <[email protected]>

Github-Pull: bitcoin#11318
Rebased-From: d552ed6
codablock pushed a commit to codablock/dash that referenced this pull request Sep 25, 2019
d552ed6 Put back inadvertently removed copyright notices (Paul Berg)

Pull request description:

  In an abundance of caution this restores "Bitcoin Developers" to the COPYING file in
  case there were contributors before that point in time that would object to the
  current label.  It's harmless and more pedantically correct.

  (Change extracted from the Bitcoin-abc github)

Tree-SHA512: ea71645fbca5548bcae750b9bb7c7cc56791d8c8d2574b778fa1666e09abad23b30fcb434f0d92c52a2eb7d7e89caa32695dff3a5a99a2ab43ed0f3636436677
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.