Integrate @JoelKatz's optimized ToHex (#562) into current HexStr function #1131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ACK |
2 similar comments
Member
|
ACK |
Contributor
|
ACK |
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
* Added net logging messages in main.cpp * Added logging for trigger removal * Improved log message for CGovernanceManager::UpdatedBlockTip * Improved log messages in CGovernanceManager::UpdateCachesAndClean * Added more logging to CGovernanceTriggerManager * Check vote validity before pushing inventory during sync * Add triggers to map after loading governance.dat file
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 22, 2019
remove unused files
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Dec 25, 2019
48a4a3c [Bug] Coded properly the URI from file read.. (furszy) Pull request description: Re coded the URI from file read. Can be easily tested parsing a file with the following text pattern: `pivx:%address%?amount=%number%?label=%text%?message=%text%` About the code that was here before, really no comments.. This solves bitcoin#1103 ACKs for top commit: Warrows: ACK 48a4a3c random-zebra: utACK 48a4a3c Tree-SHA512: 2597ef7db91c2eed012d2ec27dc6192ac82e383392254ae8cd301546ebadd661b8316e807dd8c24944614aa1916d4ff7f79b94f53c8c6d141ceef8d51bb93610
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #562 was rejected because it introduced a new ToHex function with a different, potentially less safe interface.
This pull request gives most of the speed-up (~30x on my CPU) of @JoelKatz his patch but rolls it into the current HexStr function. See the following benchmark results (made using https://gist.github.com/2439041).
It also adds two tests for HexStr: testing HexStr for the empty string and the function that takes a std::vector.