Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Sep 12, 2017

There had been intermittent test failures on zapwallettxes, as no time was allotted to reload the mempool.

@maflcko maflcko added the Tests label Sep 12, 2017
@jnewbery
Copy link
Contributor

tested ACK fadd0c1

I ran the test 100 times locally, and didn't hit any failures:

./test_runner.py $(for i in {1..100}; do echo -n 'zapwallettxes.py ' ; done)
...
ALL              | ✓ Passed  | 1096 s (accumulated) 

(however, running master 100 times also fails to hit the intermittent error, so it's not certain that this resolves the issue)

@maflcko maflcko merged commit fadd0c1 into bitcoin:master Sep 13, 2017
maflcko pushed a commit that referenced this pull request Sep 13, 2017
fadd0c1 [qa] zapwallettxes: Wait up to 3s for mempool reload (MarcoFalke)

Pull request description:

  There had been intermittent test failures on zapwallettxes, as no time was allotted to reload the mempool.

Tree-SHA512: 993254d2aaca6ea42fceefffed0cf90bdda91c64150179ef2a11337c3fe2cc6bf42b83ea9d9a1a575204fbde2676d7203443b00d053e8c2ed43e017c09d3ab11
@maflcko maflcko deleted the Mf1709-qaZap3s branch September 13, 2017 16:24
@maflcko
Copy link
Member Author

maflcko commented Sep 13, 2017

@jnewbery I think this is only apparent on systems with shared cpu and spinning disk.

maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Oct 3, 2017
codablock pushed a commit to codablock/dash that referenced this pull request Aug 8, 2019
…load

fadd0c1 [qa] zapwallettxes: Wait up to 3s for mempool reload (MarcoFalke)

Pull request description:

  There had been intermittent test failures on zapwallettxes, as no time was allotted to reload the mempool.

Tree-SHA512: 993254d2aaca6ea42fceefffed0cf90bdda91c64150179ef2a11337c3fe2cc6bf42b83ea9d9a1a575204fbde2676d7203443b00d053e8c2ed43e017c09d3ab11
UdjinM6 pushed a commit to dashpay/dash that referenced this pull request Aug 16, 2019
…load (#3051)

* Merge bitcoin#11308: [qa] zapwallettxes: Wait up to 3s for mempool reload

fadd0c1 [qa] zapwallettxes: Wait up to 3s for mempool reload (MarcoFalke)

Pull request description:

  There had been intermittent test failures on zapwallettxes, as no time was allotted to reload the mempool.

Tree-SHA512: 993254d2aaca6ea42fceefffed0cf90bdda91c64150179ef2a11337c3fe2cc6bf42b83ea9d9a1a575204fbde2676d7203443b00d053e8c2ed43e017c09d3ab11

* Fix import
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants