Skip to content

add m_added_nodes to connman options #11301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sipa merged 2 commits into from
Sep 22, 2017
Merged

add m_added_nodes to connman options #11301

sipa merged 2 commits into from
Sep 22, 2017

Conversation

@benma
Copy link

@benma benma commented Sep 11, 2017

No description provided.

@jimpo
Copy link
Contributor

jimpo commented Sep 11, 2017

utACK 35e5c22

@sipa
Copy link
Member

sipa commented Sep 12, 2017

Concept ACK, but I'd like @theuni's review.

@jnewbery
Copy link
Contributor

jnewbery commented Sep 14, 2017

slightly tested ACk 35e5c22

theuni
theuni approved these changes Sep 15, 2017
View reviewed changes
Copy link
Member

@theuni theuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 35e5c22

Though thread sanitizers may complain about the missing lock.

As a follow-up, mind moving Init() out of the header and into the cpp so that we can add more logic as necessary there? In this case, adding back the lock.

@benma
Copy link
Author

benma commented Sep 22, 2017

Ready for merge?

@sipa sipa merged commit 35e5c22 into bitcoin:master Sep 22, 2017
sipa added a commit that referenced this pull request Sep 22, 2017
@sipa
Merge #11301: add m_added_nodes to connman options
8776787 
35e5c22 remove unused IsArgSet check (Marko Bencun)
6059182 add m_added_nodes to connman options (Marko Bencun)

Pull request description:

Tree-SHA512: ca4527a964dcda816b32d335e7fe4d0d8a668a83fbc5e4707ee452d00a7089fa59a88c9f2b1ecdf50e673f2a63fc364b23979e0153f91136525eceec10c2ede2
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 12, 2020
@sipa @PastaPastaPasta
Merge bitcoin#11301: add m_added_nodes to connman options
3ba12f2 
35e5c22 remove unused IsArgSet check (Marko Bencun)
6059182 add m_added_nodes to connman options (Marko Bencun)

Pull request description:

Tree-SHA512: ca4527a964dcda816b32d335e7fe4d0d8a668a83fbc5e4707ee452d00a7089fa59a88c9f2b1ecdf50e673f2a63fc364b23979e0153f91136525eceec10c2ede2
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@dcousens dcousens dcousens approved these changes

@theuni theuni theuni approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@theuni theuni

Labels

Refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@benma @jimpo @sipa @jnewbery @dcousens @theuni @fanquake