Skip to content

Add -usehd to excluded args in check-doc.py #11285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sipa merged 1 commit into from
Sep 8, 2017
Merged

Add -usehd to excluded args in check-doc.py #11285

sipa merged 1 commit into from
Sep 8, 2017

Conversation

@meshcollider
Copy link
Contributor

@meshcollider meshcollider commented Sep 8, 2017 •
edited
Loading

All Travis builds on master are currently failing due to contrib/devtools/check-doc.py picking up -usehd in src/wallet/wallet.cpp#L3845 as an undocumented argument (removed in #11250). Just need to add it to the list of unsupported, deprecated and duplicate args in check-doc.py so that it's ignored. Otherwise all builds on top of #11250 will fail until this is merged.

@fanquake fanquake added the Tests label Sep 8, 2017
@fanquake
Copy link
Member

fanquake commented Sep 8, 2017

Failing as below, however it looks like it's only the arm-linux builds?

0.08s$ if [ "$CHECK_DOC" = 1 ]; then contrib/devtools/check-doc.py; fi
Args used        : 145
Args documented  : 172
Args undocumented: 1
set(['-usehd'])
Args unknown     : 28
set(['-blockminsize', '-version', '-addnode', '-debug', '-zmqpubrawtx', '-rpcauth', '-zmqpubhashtx', '-rpcallowip', '-zmqpubhashblock', '-vbparams', '-h', '-socks', '-rpcbind', '-onlynet', '-connect', '-help', '-seednode', '-whitelist', '-bind', '-loadblock', '-uacomment', '-zmqpubrawblock', '-whitebind', '-fuzzmessagestest', '-debugexclude', '-wallet', '-externalip', '-?'])
The command "if [ "$CHECK_DOC" = 1 ]; then contrib/devtools/check-doc.py; fi" failed and exited with 1 during .
Your build has been stopped.

@meshcollider
Copy link
Contributor Author

meshcollider commented Sep 8, 2017 •
edited
Loading

@fanquake it's only on the builds which export CHECK_DOC=1 to run check-doc.py

@promag
Copy link
Contributor

promag commented Sep 8, 2017

ACK 7d03418.

@fanquake
Copy link
Member

fanquake commented Sep 8, 2017

travis-has-passed ACK 7d03418

Does a reminder need to be added to the docs somewhere, so this doesn't happen again?

@meshcollider
Copy link
Contributor Author

meshcollider commented Sep 8, 2017

Unsure where it would be suitable to put such a thing, but if you have a place in mind it would probably be a good idea 👍

@promag
Copy link
Contributor

promag commented Sep 8, 2017

Does a reminder need to be added to the docs somewhere, so this doesn't happen again?

This problem should have been fixed in #11250 where travis should be broken (but the build was cancelled) so I guess there is no need for documentation.

@jimpo
Copy link
Contributor

jimpo commented Sep 8, 2017

ACK 7d03418

@achow101
Copy link
Member

achow101 commented Sep 8, 2017

ACK 7d03418

@sipa sipa merged commit 7d03418 into bitcoin:master Sep 8, 2017
sipa added a commit that referenced this pull request Sep 8, 2017
@sipa
Merge #11285: Add -usehd to excluded args in check-doc.py
3255d63 
7d03418 Add -usehd to excluded args in check-doc.py (MeshCollider)

Pull request description:

  All Travis builds on master are currently failing due to contrib/devtools/check-doc.py picking up `-usehd` in `src/wallet/wallet.cpp#L3845` as an undocumented argument (removed in #11250). Just need to add it to the list of unsupported, deprecated and duplicate args in check-doc.py so that it's ignored. Otherwise all builds on top of #11250 will fail until this is merged.

Tree-SHA512: 205c9be759b04bc3b85ac2b53fd455b3c0e229320d8e2b7f7d0ef5d5bd8033594b38a2d948250894ee2f4451584aca698476cd4b5cdf82955925683e3068a67c
@meshcollider meshcollider deleted the 201709_fix_usehd_checkdocs branch September 9, 2017 00:01
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@meshcollider @fanquake @promag @jimpo @achow101 @sipa