-
Notifications
You must be signed in to change notification settings - Fork 38.7k
[P2P] When clearing addrman clear mapInfo and mapAddr. #11252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
utACK b86a420 |
Contributor
|
utACK b86a420 |
Member
|
utACK b86a420 |
sipa
added a commit
that referenced
this pull request
Sep 11, 2017
b86a420 when clearing addrman clear mapInfo and mapAddr (Gregory Sanders) Pull request description: Power failure on my machine resulted in a corrupted addrman that would hit bad assertions when trying to serialize the "cleared" addrman to disk: https://github.com/bitcoin/bitcoin/blob/6866b4912b8013ed748d12250209f7079a3c92e6/src/addrman.h#L320 Tree-SHA512: 07ca8b6cbd88407e5f3f0dccb346ae31bd1392f4210b2d5c5647c853986bfec95cf70240b92bafdc61b90e452a5d8315962738d10c10c2b53fdabff10503d05a
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Oct 4, 2017
Github-Pull: bitcoin#11252 Rebased-From: b86a420
This was referenced Oct 6, 2017
Closed
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Oct 21, 2019
…pAddr. b86a420 when clearing addrman clear mapInfo and mapAddr (Gregory Sanders) Pull request description: Power failure on my machine resulted in a corrupted addrman that would hit bad assertions when trying to serialize the "cleared" addrman to disk: https://github.com/bitcoin/bitcoin/blob/6866b4912b8013ed748d12250209f7079a3c92e6/src/addrman.h#L320 Tree-SHA512: 07ca8b6cbd88407e5f3f0dccb346ae31bd1392f4210b2d5c5647c853986bfec95cf70240b92bafdc61b90e452a5d8315962738d10c10c2b53fdabff10503d05a
codablock
added a commit
to dashpay/dash
that referenced
this pull request
Oct 23, 2019
…pAddr. (#3171) b86a420 when clearing addrman clear mapInfo and mapAddr (Gregory Sanders) Pull request description: Power failure on my machine resulted in a corrupted addrman that would hit bad assertions when trying to serialize the "cleared" addrman to disk: https://github.com/bitcoin/bitcoin/blob/6866b4912b8013ed748d12250209f7079a3c92e6/src/addrman.h#L320 Tree-SHA512: 07ca8b6cbd88407e5f3f0dccb346ae31bd1392f4210b2d5c5647c853986bfec95cf70240b92bafdc61b90e452a5d8315962738d10c10c2b53fdabff10503d05a
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Dec 5, 2020
49e0112 when clearing addrman clear mapInfo and mapAddr (Gregory Sanders) Pull request description: Another quick one, from bitcoin#11252 > Power failure on my machine resulted in a corrupted addrman that would hit bad assertions when trying to serialize the "cleared" addrman to disk: ACKs for top commit: furszy: utACK 49e0112 Fuzzbawls: utACK 49e0112 Tree-SHA512: 767c9ffc552ab1b3017e342018b41bd5589d5e1157e9affedf6086eb9ccbd5dc5177b5f785d12310d8c3be954cfb832eb25847dc521e64d597595d0b08a4f76a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Power failure on my machine resulted in a corrupted addrman that would hit bad assertions when trying to serialize the "cleared" addrman to disk:
bitcoin/src/addrman.h
Line 320 in 6866b49