Skip to content

Conversation

@instagibbs
Copy link
Member

@instagibbs instagibbs commented Sep 6, 2017

Power failure on my machine resulted in a corrupted addrman that would hit bad assertions when trying to serialize the "cleared" addrman to disk:

assert(nIds != nNew); // this means nNew was wrong, oh ow

@laanwj laanwj added the P2P label Sep 6, 2017
@laanwj
Copy link
Member

laanwj commented Sep 6, 2017

utACK b86a420

@fanquake fanquake changed the title when clearing addrman clear mapInfo and mapAddr [P2P] When clearing addrman clear mapInfo and mapAddr. Sep 8, 2017
@morcos
Copy link
Contributor

morcos commented Sep 11, 2017

utACK b86a420

@sipa
Copy link
Member

sipa commented Sep 11, 2017

utACK b86a420

@sipa sipa merged commit b86a420 into bitcoin:master Sep 11, 2017
sipa added a commit that referenced this pull request Sep 11, 2017
b86a420 when clearing addrman clear mapInfo and mapAddr (Gregory Sanders)

Pull request description:

  Power failure on my machine resulted in a corrupted addrman that would hit bad assertions when trying to serialize the "cleared" addrman to disk: https://github.com/bitcoin/bitcoin/blob/6866b4912b8013ed748d12250209f7079a3c92e6/src/addrman.h#L320

Tree-SHA512: 07ca8b6cbd88407e5f3f0dccb346ae31bd1392f4210b2d5c5647c853986bfec95cf70240b92bafdc61b90e452a5d8315962738d10c10c2b53fdabff10503d05a
@theuni theuni added this to the 0.15.1 milestone Sep 27, 2017
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Oct 4, 2017
codablock pushed a commit to codablock/dash that referenced this pull request Oct 21, 2019
…pAddr.

b86a420 when clearing addrman clear mapInfo and mapAddr (Gregory Sanders)

Pull request description:

  Power failure on my machine resulted in a corrupted addrman that would hit bad assertions when trying to serialize the "cleared" addrman to disk: https://github.com/bitcoin/bitcoin/blob/6866b4912b8013ed748d12250209f7079a3c92e6/src/addrman.h#L320

Tree-SHA512: 07ca8b6cbd88407e5f3f0dccb346ae31bd1392f4210b2d5c5647c853986bfec95cf70240b92bafdc61b90e452a5d8315962738d10c10c2b53fdabff10503d05a
codablock added a commit to dashpay/dash that referenced this pull request Oct 23, 2019
…pAddr. (#3171)

b86a420 when clearing addrman clear mapInfo and mapAddr (Gregory Sanders)

Pull request description:

  Power failure on my machine resulted in a corrupted addrman that would hit bad assertions when trying to serialize the "cleared" addrman to disk: https://github.com/bitcoin/bitcoin/blob/6866b4912b8013ed748d12250209f7079a3c92e6/src/addrman.h#L320

Tree-SHA512: 07ca8b6cbd88407e5f3f0dccb346ae31bd1392f4210b2d5c5647c853986bfec95cf70240b92bafdc61b90e452a5d8315962738d10c10c2b53fdabff10503d05a
random-zebra added a commit to PIVX-Project/PIVX that referenced this pull request Dec 5, 2020
49e0112 when clearing addrman clear mapInfo and mapAddr (Gregory Sanders)

Pull request description:

  Another quick one, from bitcoin#11252

  > Power failure on my machine resulted in a corrupted addrman that would hit bad assertions when trying to serialize the "cleared" addrman to disk:

ACKs for top commit:
  furszy:
    utACK 49e0112
  Fuzzbawls:
    utACK 49e0112

Tree-SHA512: 767c9ffc552ab1b3017e342018b41bd5589d5e1157e9affedf6086eb9ccbd5dc5177b5f785d12310d8c3be954cfb832eb25847dc521e64d597595d0b08a4f76a
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants