Docs: Add extra step to clean $PATH var to strip out windows %PATH% paths. #11244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I am not sure if version Ubuntu Trusty 14.04 pulls in the Windows %PATH% variable? I am using the latest Ubuntu Xenial 16.04 which has more issues cross compiling as mentioned in #10269 . If 14.04 does not pull in %PATH% thus not causing the issue this doc addition tries to fix then please reject this PR. Thanks. |
Member
|
Overlaps with #10889 |
Member
Not sure either, it doesn't hurt to add the step in any case, it will likely still be needed for 18.04. |
Member
|
Started testing this. Going to upgrade to Ubuntu 16.04/10 and test. |
Member
|
Upgraded WSL to 16.04.3, and tried building c22a53c using these instructions. The result is as expected. Upgraded WSL to 17.04 and tried building 3255d63 using these instructions + @laanwj's info from #8732. That works successfully. I think it'd be worthwhile adding the posix alternative info to the readme, or at least mentioning that 17.04 will work with a simple workaround, given how many issues we've seen over the past few months. |
This was referenced Sep 25, 2017
Member
|
@donaloconnor I'd like to cherry-pick this commit, but I can't seem to as the author info is missing. Could you either push up a commit with author information, or do you mind if I take the changes as they are, and credit you in my new commit? |
…ATH% paths that cause issues with the make system
donaloconnor
force-pushed
the
windows_build_fix
branch
from
6e6ee9e to
e66c2b4
Compare
Contributor
Author
|
@fanquake - I think it should be okay now? I'm still getting my head around git so apologies if this doesn't work. If it doesn't then I'm good with credit in your commit. Cheers. |
Member
|
@donaloconnor Thanks. Closing this PR in favour of #11437. |
laanwj
added a commit
that referenced
this pull request
Oct 5, 2017
…and Ubuntu 17.04 696ce46 [Docs] Update Windows build instructions for using WSL and Ubuntu 17.04 (fanquake) 4f890ba Add new step to clean $PATH var by removing /mnt specific Window's %PATH% paths that cause issues with the make system (Donal OConnor) Pull request description: This updates the Windows build documentation with the workaround required to build using Ubuntu 17.04 on WSL, and makes it's explicit that building on Ubuntu 16.04 is broken, and not recommended. This includes a commit from @donaloconnor in #11244, and is mostly the investigative work of @laanwj throughout #8732, #8653 and quite a few other issues. I tested building on 14.04, 16.04.3 and 17.04 [here](#11244 (comment)) and got the results we expect. --- Built master at c22a53c on a Windows 10 VM (Version 1607, OS Build 14393.1593) using WSL with Ubuntu 14.04.  Upgraded WSL to 16.04.3, and tried building c22a53c using these instructions. The result is as expected.  Upgraded WSL to 17.04 and tried building 3255d63 using these instructions.  If someone else could also verify that builds are working on both 14.04 and 17.04 with these instructions, that would be great. Tree-SHA512: 866f1003eb45d208d8ae849504f54fc2f27c32240129d2124ce5a2ee7167bcbf062d29f23b1745123f532ffd0253a8611e719b2a316d1331d3c3924f91e7775d
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Sep 25, 2019
…ng WSL and Ubuntu 17.04 696ce46 [Docs] Update Windows build instructions for using WSL and Ubuntu 17.04 (fanquake) 4f890ba Add new step to clean $PATH var by removing /mnt specific Window's %PATH% paths that cause issues with the make system (Donal OConnor) Pull request description: This updates the Windows build documentation with the workaround required to build using Ubuntu 17.04 on WSL, and makes it's explicit that building on Ubuntu 16.04 is broken, and not recommended. This includes a commit from @donaloconnor in bitcoin#11244, and is mostly the investigative work of @laanwj throughout bitcoin#8732, bitcoin#8653 and quite a few other issues. I tested building on 14.04, 16.04.3 and 17.04 [here](bitcoin#11244 (comment)) and got the results we expect. --- Built master at bitcoin@c22a53c on a Windows 10 VM (Version 1607, OS Build 14393.1593) using WSL with Ubuntu 14.04.  Upgraded WSL to 16.04.3, and tried building bitcoin@c22a53c using these instructions. The result is as expected.  Upgraded WSL to 17.04 and tried building bitcoin@3255d63 using these instructions.  If someone else could also verify that builds are working on both 14.04 and 17.04 with these instructions, that would be great. Tree-SHA512: 866f1003eb45d208d8ae849504f54fc2f27c32240129d2124ce5a2ee7167bcbf062d29f23b1745123f532ffd0253a8611e719b2a316d1331d3c3924f91e7775d
charlesrocket
pushed a commit
to AXErunners/axe
that referenced
this pull request
Dec 15, 2019
…and Ubuntu 17.04 696ce46 [Docs] Update Windows build instructions for using WSL and Ubuntu 17.04 (fanquake) 4f890ba Add new step to clean $PATH var by removing /mnt specific Window's %PATH% paths that cause issues with the make system (Donal OConnor) Pull request description: This updates the Windows build documentation with the workaround required to build using Ubuntu 17.04 on WSL, and makes it's explicit that building on Ubuntu 16.04 is broken, and not recommended. This includes a commit from @donaloconnor in #11244, and is mostly the investigative work of @laanwj throughout #8732, #8653 and quite a few other issues. I tested building on 14.04, 16.04.3 and 17.04 [here](bitcoin/bitcoin#11244 (comment)) and got the results we expect. --- Built master at bitcoin/bitcoin@c22a53c on a Windows 10 VM (Version 1607, OS Build 14393.1593) using WSL with Ubuntu 14.04.  Upgraded WSL to 16.04.3, and tried building bitcoin/bitcoin@c22a53c using these instructions. The result is as expected.  Upgraded WSL to 17.04 and tried building bitcoin/bitcoin@3255d63 using these instructions.  If someone else could also verify that builds are working on both 14.04 and 17.04 with these instructions, that would be great. Tree-SHA512: 866f1003eb45d208d8ae849504f54fc2f27c32240129d2124ce5a2ee7167bcbf062d29f23b1745123f532ffd0253a8611e719b2a316d1331d3c3924f91e7775d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experienced the same ( error mentioned in #10269) . The suggested extra step in this PR removes the problematic Windows paths from the $PATH var.