[tests] fixup dbcrash interaction with add_nodes() #11230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
Sep 4, 2017
| def setup_network(self): | ||
| # Need a bit of extra time for the nodes to start up for this test | ||
| self.add_nodes(self.num_nodes, timewait=90) | ||
| self.add_nodes(self.num_nodes, extra_args=self.extra_args, timewait=90) |
Member
There was a problem hiding this comment.
We might as well get rid of passing member variables to methods.
Contributor
Author
There was a problem hiding this comment.
Agree, but I haven't looked into how big a change that would be (I'd need to look at all calls to add_nodes() to make sure they're not calling this method with no extra_args method and expecting the node to be started with any extra_args equal to [])
Member
|
ACK, this fixes |
maflcko
pushed a commit
that referenced
this pull request
Sep 12, 2017
8fdb6f9 [tests] fixup dbcrash interaction with add_nodes() (John Newbery) Pull request description: Another conflict with #11121. Apologies - this is entirely my fault. I didn't run the extended test suite after rebasing on master. @MarcoFalke @sdaftuar Tree-SHA512: eefce1d1c63dc4a63c5e030a541e046ad4832e8a709c0a8aad40ffdc4712b2065486778b406dfa57cfd34e66db86064278ee3fea8f2c2afd2390772875e6fa3e
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Oct 3, 2017
Github-Pull: bitcoin#11230 Rebased-From: 8fdb6f9
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Sep 24, 2019
8fdb6f9 [tests] fixup dbcrash interaction with add_nodes() (John Newbery) Pull request description: Another conflict with bitcoin#11121. Apologies - this is entirely my fault. I didn't run the extended test suite after rebasing on master. @MarcoFalke @sdaftuar Tree-SHA512: eefce1d1c63dc4a63c5e030a541e046ad4832e8a709c0a8aad40ffdc4712b2065486778b406dfa57cfd34e66db86064278ee3fea8f2c2afd2390772875e6fa3e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another conflict with #11121. Apologies - this is entirely my fault. I didn't run the extended test suite after rebasing on master.
@MarcoFalke @sdaftuar