Stop test_bitcoin-qt touching ~/.bitcoin #11210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Travis failure is in an unrelated test, please rerun :) |
Contributor
|
utACK dea086f |
1 similar comment
Contributor
|
utACK dea086f |
sipa
reviewed
Sep 3, 2017
| SetupNetworking(); | ||
| SelectParams(CBaseChainParams::MAIN); | ||
| noui_connect(); | ||
| ClearDatadirCache(); |
Member
There was a problem hiding this comment.
We already do it on src/test/test_bitcoin.cpp
Member
|
Tested ACK dea086f, thanks! |
laanwj
added a commit
that referenced
this pull request
Sep 6, 2017
dea086f Stop test_bitcoin-qt touching ~/.bitcoin (MeshCollider) Pull request description: Fixes #11192 The directory remains unused, but this stops the tests touching ~/.bitcoin at all (namely creating it if it doesn't exist) Tree-SHA512: e59ad6b83dbc5ea2fb2761994c09933721d29668b0eef09b9d938a4ee1c67871c5125c57483ee0ea25f2385e308d275d86bcb9087dd4d502923013b4f3dbac82
Member
|
@MarcoFalke mentioned needing a test for this on travis (that the tests don't touch |
Member
|
Making sure that |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Oct 3, 2017
Github-Pull: bitcoin#11210 Rebased-From: dea086f
Member
|
@MarcoFalke Eh, we can just add a check that |
Member
|
Iirc we did that and it failed occasionally. This is on my list of things
to take a look at ...
…On Nov 10, 2017 04:06, "Luke Dashjr" ***@***.***> wrote:
@MarcoFalke <https://github.com/marcofalke> Eh, we can just add a check
that ~/.bitcoin still doesn't exist at the end?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11210 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGGmv7gKKJCFcDv-SytUAyUvBZFKuA32ks5s1BIcgaJpZM4PKBvu>
.
|
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Sep 24, 2019
dea086f Stop test_bitcoin-qt touching ~/.bitcoin (MeshCollider) Pull request description: Fixes bitcoin#11192 The directory remains unused, but this stops the tests touching ~/.bitcoin at all (namely creating it if it doesn't exist) Tree-SHA512: e59ad6b83dbc5ea2fb2761994c09933721d29668b0eef09b9d938a4ee1c67871c5125c57483ee0ea25f2385e308d275d86bcb9087dd4d502923013b4f3dbac82
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11192
The directory remains unused, but this stops the tests touching ~/.bitcoin at all (namely creating it if it doesn't exist)