Skip to content

Conversation

@laanwj
Copy link
Member

@laanwj laanwj commented Aug 18, 2017

When running the tests locally with a parallelism of 4 on an otherwise busy system, RPC can take quite a wait to come up.

With the current timeout tests often fail with "Unable to connect to bitcoind".

Change the timeout to 60 seconds just to be safe.

@laanwj laanwj added the Tests label Aug 18, 2017
Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK ea1adc6.

@achow101
Copy link
Member

utACK ea1adc6726ed753db7737a6b8ab772c081037211

@meshcollider
Copy link
Contributor

utACK ea1adc6

@fanquake
Copy link
Member

This is related to #11077. Ping @jnewbery.

@jnewbery
Copy link
Contributor

utACK. I'm afk until Wednesday so I can't test, but this seems like a reasonable change.

Slight preference for the variable names within the function to be lower case.

When running the tests locally with a parallelism of 4 on an otherwise
busy system, RPC can take quite a wait to come up.

Change the timeout to 60 seconds just to be safe.
@laanwj laanwj force-pushed the 2017_08_test_wait_for_rpc branch from ea1adc6 to c1470a0 Compare August 20, 2017 13:03
@laanwj
Copy link
Member Author

laanwj commented Aug 20, 2017

ea1adc6 → c1470a0 only changed the case of the variables

@fanquake
Copy link
Member

utACK c1470a0

@laanwj laanwj merged commit c1470a0 into bitcoin:master Aug 20, 2017
laanwj added a commit that referenced this pull request Aug 20, 2017
c1470a0 test: Increase initial RPC timeout to 60 seconds (Wladimir J. van der Laan)

Pull request description:

  When running the tests locally with a parallelism of 4 on an otherwise busy system, RPC can take quite a wait to come up.

  With the current timeout tests often fail with "Unable to connect to bitcoind".

  Change the timeout to 60 seconds just to be safe.

Tree-SHA512: 0c08cc8ce3f25ba2882beac2a50d1fcdd7c8c3bd6e3a8707813f94f2d39c14e2139ba1ddf7f9b66013d4c7f55db92d3f4aa88b433d855fd21e82842e350e459a
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Oct 3, 2017
When running the tests locally with a parallelism of 4 on an otherwise
busy system, RPC can take quite a wait to come up.

Change the timeout to 60 seconds just to be safe.

Github-Pull: bitcoin#11091
Rebased-From: c1470a0
codablock pushed a commit to codablock/dash that referenced this pull request Sep 24, 2019
c1470a0 test: Increase initial RPC timeout to 60 seconds (Wladimir J. van der Laan)

Pull request description:

  When running the tests locally with a parallelism of 4 on an otherwise busy system, RPC can take quite a wait to come up.

  With the current timeout tests often fail with "Unable to connect to bitcoind".

  Change the timeout to 60 seconds just to be safe.

Tree-SHA512: 0c08cc8ce3f25ba2882beac2a50d1fcdd7c8c3bd6e3a8707813f94f2d39c14e2139ba1ddf7f9b66013d4c7f55db92d3f4aa88b433d855fd21e82842e350e459a
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants