-
Notifications
You must be signed in to change notification settings - Fork 38.7k
test: Increase initial RPC timeout to 60 seconds #11091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
promag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK ea1adc6.
|
utACK ea1adc6726ed753db7737a6b8ab772c081037211 |
|
utACK ea1adc6 |
|
utACK. I'm afk until Wednesday so I can't test, but this seems like a reasonable change. Slight preference for the variable names within the function to be lower case. |
When running the tests locally with a parallelism of 4 on an otherwise busy system, RPC can take quite a wait to come up. Change the timeout to 60 seconds just to be safe.
ea1adc6 to
c1470a0
Compare
|
ea1adc6 → c1470a0 only changed the case of the variables |
|
utACK c1470a0 |
c1470a0 test: Increase initial RPC timeout to 60 seconds (Wladimir J. van der Laan) Pull request description: When running the tests locally with a parallelism of 4 on an otherwise busy system, RPC can take quite a wait to come up. With the current timeout tests often fail with "Unable to connect to bitcoind". Change the timeout to 60 seconds just to be safe. Tree-SHA512: 0c08cc8ce3f25ba2882beac2a50d1fcdd7c8c3bd6e3a8707813f94f2d39c14e2139ba1ddf7f9b66013d4c7f55db92d3f4aa88b433d855fd21e82842e350e459a
When running the tests locally with a parallelism of 4 on an otherwise busy system, RPC can take quite a wait to come up. Change the timeout to 60 seconds just to be safe. Github-Pull: bitcoin#11091 Rebased-From: c1470a0
c1470a0 test: Increase initial RPC timeout to 60 seconds (Wladimir J. van der Laan) Pull request description: When running the tests locally with a parallelism of 4 on an otherwise busy system, RPC can take quite a wait to come up. With the current timeout tests often fail with "Unable to connect to bitcoind". Change the timeout to 60 seconds just to be safe. Tree-SHA512: 0c08cc8ce3f25ba2882beac2a50d1fcdd7c8c3bd6e3a8707813f94f2d39c14e2139ba1ddf7f9b66013d4c7f55db92d3f4aa88b433d855fd21e82842e350e459a
When running the tests locally with a parallelism of 4 on an otherwise busy system, RPC can take quite a wait to come up.
With the current timeout tests often fail with "Unable to connect to bitcoind".
Change the timeout to 60 seconds just to be safe.