qa: Move wait_until to util #11068
Merged
qa: Move wait_until to util #11068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I don't love this name, but we can tidy up in a later commit so concept ACK (since it's required for #11067) |
maflcko
force-pushed
the
Mf1708-qaWaitUntilMiniNode
branch
from
faf681e to
02a75ed
Compare
maflcko
force-pushed
the
Mf1708-qaWaitUntilMiniNode
branch
from
02a75ed to
08ce33f
Compare
maflcko
changed the title
Member
Author
|
@jnewbery I pushed my preferred version. No need for unwanted intermediate
commits.
…On Aug 16, 2017 11:26 PM, "John Newbery" ***@***.***> wrote:
I don't love this name, but we can tidy up in a later commit so concept
ACK (since it's required for #11067
<#11067>)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11068 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGGmv4HFA4y15floZY_QxDOqIJxhqa46ks5sY16hgaJpZM4O5J4L>
.
|
Contributor
|
Great! Tested ACK 08ce33f . I've long wanted to move the assert up into This is a good change. |
maflcko
pushed a commit
that referenced
this pull request
Aug 23, 2017
08ce33f qa: Move wait_until to util (MarcoFalke) Pull request description: This moves `wait_until` to `util.py` to make it generally available to python tests. Also, `wait_until` now takes an optional lock that is acquired while testing the predicate. Previously the lock was always acquired, even when it was not necessary, cf. `disconnect_ban.py`. Tree-SHA512: 18e452a017a6566fa8ad09bde058e1b841e167039dc63299e70cfa7a6dcbc779581e60ca3e8eb2f1b610767d5208b9376c203eb11015b250fd0542b5eb4215a8
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Oct 3, 2017
Github-Pull: bitcoin#11068 Rebased-From: 08ce33f
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Sep 24, 2019
08ce33f qa: Move wait_until to util (MarcoFalke) Pull request description: This moves `wait_until` to `util.py` to make it generally available to python tests. Also, `wait_until` now takes an optional lock that is acquired while testing the predicate. Previously the lock was always acquired, even when it was not necessary, cf. `disconnect_ban.py`. Tree-SHA512: 18e452a017a6566fa8ad09bde058e1b841e167039dc63299e70cfa7a6dcbc779581e60ca3e8eb2f1b610767d5208b9376c203eb11015b250fd0542b5eb4215a8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
wait_untiltoutil.pyto make it generally available to python tests.Also,
wait_untilnow takes an optional lock that is acquired while testing the predicate.Previously the lock was always acquired, even when it was not necessary, cf.
disconnect_ban.py.