Fix resendwallettransactions assert failure if -walletbroadcast=0 #10995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
utACK |
Member
|
utACK 48ff1822a007195640299f728d75b52e6d4a22a6 |
Contributor
|
Even though |
Contributor
Author
|
@promag seems reasonable, I added a commit to do so. |
promag
reviewed
Aug 7, 2017
Contributor
promag
left a comment
promag
left a comment
There was a problem hiding this comment.
Concept ACK modulus comments.
src/wallet/rpcwallet.cpp
Outdated
src/wallet/wallet.cpp
Outdated
Contributor
There was a problem hiding this comment.
Remove and let it hit assert.
src/wallet/rpcwallet.cpp
Outdated
Contributor
There was a problem hiding this comment.
In the help you reference the app arg, but not in the error message. Make them consistent?
Contributor
Author
|
Fixed issues and squashed. |
TheBlueMatt
force-pushed
the
2018-08-walletbroadcast-assert
branch
from
b42d651 to
01699fb
Compare
laanwj
added a commit
that referenced
this pull request
Aug 7, 2017
…roadcast=0 01699fb Fix resendwallettransactions assert failure if -walletbroadcast=0 (Matt Corallo) Pull request description: This fixes #10981 in my preferred way. Tree-SHA512: 2e43d3ac78d13c5d59db23a82c76c722cc3344767a8237617080e489296d27a98bb1b3bd469b2c9b289b57a9da3709c90448d7a23bcc2e1dfb791c4fd16be015
|
Plz send me some where to learn this im confused and screwing up everything |
Contributor
|
Post-merge comment: application-level errors should not use |
laanwj
added a commit
that referenced
this pull request
Aug 8, 2017
…nsaction 055d95f [wallet] return correct error code from resendwallettransaction (John Newbery) Pull request description: New code in #10995 uses `RPC_INVALID_REQUEST`. According to the comment in rpc/protocol.h: ``` // RPC_INVALID_REQUEST is internally mapped to HTTP_BAD_REQUEST (400). // It should not be used for application-layer errors. ``` Change the returned error code to `RPC_WALLET_ERROR` #11000 will need to be updated to test for the correct error code. Tree-SHA512: 0201b3a2091adf17ad301825da5bd29f0ea7e284b5394cbef80483fc293a558acc849f74a0780bb8501acab324fc722e41ae049cffec7afb76884e26df4b809e
maflcko
pushed a commit
that referenced
this pull request
Aug 12, 2017
bdf607e test: Add resendwallettransactions functional tests (João Barbosa) Pull request description: Adds functional tests to cover the behaviour introduced in #10995. Tree-SHA512: 3be337cbe51edab2cc0eb9ecfa68d00cd3c3a00aef0672cd841706802726c9cd4138626a8f209c3d9fbd207ce332daa062f270e4c94c1c2398bfc475e36423f6
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Aug 2, 2019
bdf607e test: Add resendwallettransactions functional tests (João Barbosa) Pull request description: Adds functional tests to cover the behaviour introduced in bitcoin#10995. Tree-SHA512: 3be337cbe51edab2cc0eb9ecfa68d00cd3c3a00aef0672cd841706802726c9cd4138626a8f209c3d9fbd207ce332daa062f270e4c94c1c2398bfc475e36423f6
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Aug 5, 2019
…walletbroadcast=0 01699fb Fix resendwallettransactions assert failure if -walletbroadcast=0 (Matt Corallo) Pull request description: This fixes bitcoin#10981 in my preferred way. Tree-SHA512: 2e43d3ac78d13c5d59db23a82c76c722cc3344767a8237617080e489296d27a98bb1b3bd469b2c9b289b57a9da3709c90448d7a23bcc2e1dfb791c4fd16be015
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Aug 5, 2019
…llettransaction 055d95f [wallet] return correct error code from resendwallettransaction (John Newbery) Pull request description: New code in bitcoin#10995 uses `RPC_INVALID_REQUEST`. According to the comment in rpc/protocol.h: ``` // RPC_INVALID_REQUEST is internally mapped to HTTP_BAD_REQUEST (400). // It should not be used for application-layer errors. ``` Change the returned error code to `RPC_WALLET_ERROR` bitcoin#11000 will need to be updated to test for the correct error code. Tree-SHA512: 0201b3a2091adf17ad301825da5bd29f0ea7e284b5394cbef80483fc293a558acc849f74a0780bb8501acab324fc722e41ae049cffec7afb76884e26df4b809e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #10981 in my preferred way.