Skip to content

Add undocumented -forcecompactdb to force LevelDB compactions #10985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Aug 5, 2017
Merged

Add undocumented -forcecompactdb to force LevelDB compactions #10985

laanwj merged 1 commit into from
Aug 5, 2017

Conversation

@sipa
Copy link
Member

@sipa sipa commented Aug 3, 2017

No description provided.

@sipa sipa force-pushed the 20170803_forcecompactdb branch from 0acfeb2 to b655dfe Compare August 3, 2017 23:26
@maflcko
Copy link
Member

maflcko commented Aug 4, 2017

The option names don't match. Pick one ;)

@sipa sipa force-pushed the 20170803_forcecompactdb branch from b655dfe to 8842d1a Compare August 4, 2017 06:42
@sipa
Copy link
Member Author

sipa commented Aug 4, 2017

I tested it, it instantly ran a 20-minute compaction operation (spinning disk, encrypted/compressed ZFS volume). It slightly reduced the size (though it was only 2.something GB already). During the operation, the usage increased to 3.something GB and went down again.

@achow101
Copy link
Member

achow101 commented Aug 4, 2017

ACK 8842d1a

Compaction of block index time with txindex: 1 hour 3 min
Block index had no size change, 12 GB before and after

Compaction of chainstate time: 10 min
Chainstate reduced from 5.9 GB to 2.7 GB

@TheBlueMatt
Copy link
Contributor

TheBlueMatt commented Aug 4, 2017

utACK

gmaxwell
gmaxwell approved these changes Aug 5, 2017
View reviewed changes
Copy link
Contributor

@gmaxwell gmaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

2017-08-04 23:41:19 Starting database compaction of /home/gmaxwell/.bitcoin/blocks/index
2017-08-04 23:41:23 Finished database compaction of /home/gmaxwell/.bitcoin/blocks/index
2017-08-04 23:41:29 Starting database compaction of /home/gmaxwell/.bitcoin/chainstate
2017-08-04 23:45:54 Finished database compaction of /home/gmaxwell/.bitcoin/chainstate

on my slow laptop, which only had about 1GB free, now it has 4.3GB free!

Running it again when already compacted (and no new blocks processed) gave:

2017-08-04 23:55:20 Starting database compaction of /home/gmaxwell/.bitcoin/blocks/index
2017-08-04 23:55:20 Finished database compaction of /home/gmaxwell/.bitcoin/blocks/index
2017-08-04 23:55:25 Starting database compaction of /home/gmaxwell/.bitcoin/chainstate
2017-08-04 23:55:25 Finished database compaction of /home/gmaxwell/.bitcoin/chainstate

Then after syncing 174 blocks:

2017-08-05 00:04:41 Starting database compaction of /home/gmaxwell/.bitcoin/blocks/index
2017-08-05 00:04:44 Finished database compaction of /home/gmaxwell/.bitcoin/blocks/index
2017-08-05 00:04:49 Starting database compaction of /home/gmaxwell/.bitcoin/chainstate
2017-08-05 00:13:49 Finished database compaction of /home/gmaxwell/.bitcoin/chainstate

@laanwj
Copy link
Member

laanwj commented Aug 5, 2017

utACK 8842d1a

@laanwj laanwj merged commit 8842d1a into bitcoin:master Aug 5, 2017
laanwj added a commit that referenced this pull request Aug 5, 2017
@laanwj
Merge #10985: Add undocumented -forcecompactdb to force LevelDB compa…
d896d5c 
…ctions

8842d1a Add undocumented -forcecompactdb to force LevelDB compactions (Pieter Wuille)

Pull request description:

Tree-SHA512: de91f3f574f75248fa6e5091089c840957fae5a972ebcd2b89493f7d777d4658560a6f5a3b43ab0c9b2c333ad98f9f185ae224c9caffc1a5e8df369cc414f123
codablock pushed a commit to codablock/dash that referenced this pull request Oct 26, 2017
@laanwj @codablock
Merge bitcoin#10985: Add undocumented -forcecompactdb to force LevelD…
790e07a 
…B compactions

8842d1a Add undocumented -forcecompactdb to force LevelDB compactions (Pieter Wuille)

Pull request description:

Tree-SHA512: de91f3f574f75248fa6e5091089c840957fae5a972ebcd2b89493f7d777d4658560a6f5a3b43ab0c9b2c333ad98f9f185ae224c9caffc1a5e8df369cc414f123
codablock pushed a commit to codablock/dash that referenced this pull request Oct 31, 2017
@laanwj @codablock
Merge bitcoin#10985: Add undocumented -forcecompactdb to force LevelD…
8780c76 
…B compactions

8842d1a Add undocumented -forcecompactdb to force LevelDB compactions (Pieter Wuille)

Pull request description:

Tree-SHA512: de91f3f574f75248fa6e5091089c840957fae5a972ebcd2b89493f7d777d4658560a6f5a3b43ab0c9b2c333ad98f9f185ae224c9caffc1a5e8df369cc414f123
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Aug 12, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10985: Add undocumented -forcecompactdb to force LevelD…
cfc6975 
…B compactions

8842d1a Add undocumented -forcecompactdb to force LevelDB compactions (Pieter Wuille)

Pull request description:

Tree-SHA512: de91f3f574f75248fa6e5091089c840957fae5a972ebcd2b89493f7d777d4658560a6f5a3b43ab0c9b2c333ad98f9f185ae224c9caffc1a5e8df369cc414f123
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@gmaxwell gmaxwell gmaxwell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Scripts and tools UTXO Db and Indexes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sipa @maflcko @achow101 @TheBlueMatt @laanwj @gmaxwell