Punctuation/grammer fixes in rpcwallet.cpp #10789
Conversation
|
NACK, disagree with the addition of full stops to every line and most of the changes in capitalization. Only a couple of the changes are valid spelling fixes, prefer if they were isolated from the rest |
|
Isolated spelling fixes and reverted all but one capitalization. Will revert that too if needed, thanks. |
src/wallet/rpcwallet.cpp
Outdated
There was a problem hiding this comment.
Ideally we include wallet.h's DEFAULT_TX_CONFIRM_TARGET here somehow.
There was a problem hiding this comment.
Should I code up a solution to that in this PR?
There was a problem hiding this comment.
No. It's a different concept
|
I'll tidy up the places where the const char needs to be an unsigned int. |
|
Open to suggestions on a better approach for string-ifying |
src/wallet/rpcwallet.cpp
Outdated
There was a problem hiding this comment.
lol, lets remove the "very safe" doge-speak...
|
NACK. I don't like tying the DEFAULT_TX_CONFIRM_TARGET to the concept of how many confirmations we might want to wait before considering a transaction to have low chance of being re-orged out. These are unrelated concepts that just both happen to use the number 6 right now. |
|
What about adding a different constant? |
|
Updated to address @morcos feedback. |
|
Very grammar, much pull request, merge now wow. |
|
utACK e439bebdc03ea42bb76c4fce9edbaf0470ddd3d9 |
|
utACK a5ecaf1, we should take this for 15. |
a5ecaf1 Fix misspellings and remove safety verbiage (Steven D. Lander) Pull request description: Standardizing punctuation on CLI output and also including a few fixes for grammer. This PR is for text only changes and includes no code edits. Tree-SHA512: afde551bf1212838822188b6723f2bf1b7222decfa1cd7aa6b04967489108a29f80833af6059252af028c53437755f258275af0614e0d4d0311e09421cd8e131
a5ecaf1 Fix misspellings and remove safety verbiage (Steven D. Lander) Pull request description: Standardizing punctuation on CLI output and also including a few fixes for grammer. This PR is for text only changes and includes no code edits. Tree-SHA512: afde551bf1212838822188b6723f2bf1b7222decfa1cd7aa6b04967489108a29f80833af6059252af028c53437755f258275af0614e0d4d0311e09421cd8e131
8 participants
Standardizing punctuation on CLI output and also including a few fixes for grammer. This PR is for text only changes and includes no code edits.