Avoid dereference-of-casted-pointer #10760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promag
reviewed
Jul 7, 2017
src/core_memusage.h
Outdated
Contributor
There was a problem hiding this comment.
Remove static cast?
return memusage::DynamicUsage(script);In my system it builds fine.
src/wallet/walletdb.cpp
Outdated
Contributor
There was a problem hiding this comment.
Removing the cast, shouldn't the compiler resolve to:
template<typename Stream, unsigned int N, typename T>
inline void Serialize(Stream& os, const prevector<N, T>& v)If not I think we could implement CScript::Serialize to call super and drop all of these casts.
Member
Author
There was a problem hiding this comment.
I somehow remembered that this didn't work, but it seems I was wrong. Fixed.
Contributor
|
Concept ACK 8be4385d64c5a50c63834b75c06d1b27d66ddb62 Regarding the |
sipa
force-pushed
the
20170707_avoidcastptr
branch
from
8be4385 to
0aadc11
Compare
Contributor
|
tACK. |
Contributor
|
utACK 0aadc11 |
dcousens
approved these changes
Jul 10, 2017
Member
What is the rationale here? Just code cleanup? |
Member
Author
|
Yes, cleanup. The existing practice risks hiding some bugs. |
Contributor
|
utACK 0aadc11 |
sipa
added a commit
that referenced
this pull request
Jul 15, 2017
0aadc11 Avoid dereference-of-casted-pointer (Pieter Wuille) Pull request description: And prefer a static_cast to the intended reference type. Tree-SHA512: e83b20023a4dca6029b46f7040a8a6fd54e1b42112ec0c87c3c3b567ed641de97a9e2335b57a2efb075491f641e5b977bc226a474276bea0c3c3c71d8d6ac54d
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 24, 2019
0aadc11 Avoid dereference-of-casted-pointer (Pieter Wuille) Pull request description: And prefer a static_cast to the intended reference type. Tree-SHA512: e83b20023a4dca6029b46f7040a8a6fd54e1b42112ec0c87c3c3b567ed641de97a9e2335b57a2efb075491f641e5b977bc226a474276bea0c3c3c71d8d6ac54d
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 24, 2019
Signed-off-by: Pasta <[email protected]>
furszy
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Feb 6, 2021
206a6d6 Avoid dereference-of-casted-pointer (Pieter Wuille) Pull request description: Straightforward cleanup, from bitcoin#10760 ACKs for top commit: furszy: re-utACK 206a6d6 Fuzzbawls: utACK 206a6d6 Tree-SHA512: ef36994afe9fe2fc3b9ce5f88cdc77c89617bfd642d98a3fc83cb030063cc2ebb3537dca98b23e02a341a7e64d78fd5d715ee74a72b79c6ac455ecd67e841096
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And prefer a static_cast to the intended reference type.