Make mapBlockIndex and chainActive and all CBlockIndex*es const outside of validation/CChainState #10692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Concept ACK. Needs rebase! :-) |
Merged
-BEGIN VERIFY SCRIPT- sed -i "s/\(const \)*CBlockIndex/const CBlockIndex/" src/qt/transactionrecord.cpp src/rest.cpp src/miner.cpp src/init.cpp src/rpc/*.cpp src/wallet/*.cpp -END VERIFY SCRIPT-
-BEGIN VERIFY SCRIPT- sed -i "s/BlockMap::iterator/BlockMap::const_iterator/" src/rpc/*.cpp src/wallet/*.cpp src/qt/transactionrecord.cpp src/net_processing.cpp -END VERIFY SCRIPT-
-BEGIN VERIFY SCRIPT- sed -i "s/mapBlockIndex\[\(.*\)\]/mapBlockIndex.at(\1)/g" src/rest.cpp src/wallet/*.cpp src/rpc/*.cpp -END VERIFY SCRIPT-
-BEGIN VERIFY SCRIPT- sed -i "s/BlockMap::iterator/NonConstBlockMap::iterator/" src/validation.cpp -END VERIFY SCRIPT-
-BEGIN VERIFY SCRIPT- sed -i "s/chainActive\./nonConstChainActive./" src/test/miner_tests.cpp -END VERIFY SCRIPT-
TheBlueMatt
force-pushed
the
2017-04-const-mapblockindex
branch
from
71bc8a4 to
bbe2069
Compare
Contributor
Author
|
Rebased. |
Contributor
Author
|
Superceded. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #10279 and is all just pretty mechanical (largely scripted) changes to make mapBlockIndex/chainActive/CBlockIndex*es const outside of validation.cpp/CChainState!