Skip to content

Conversation

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Jun 8, 2017

Remove duplicate includes.

@achow101
Copy link
Member

achow101 commented Jun 8, 2017

utACK 26441d565faf434a9e05884c767b211bf256824e

@fanquake
Copy link
Member

fanquake commented Jun 9, 2017

utACK 26441d5

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove the other one instead, to keep the wallet/ imports together?

@practicalswift practicalswift force-pushed the remove-duplicate-includes branch from 26441d5 to d7723ab Compare June 9, 2017 05:38
@practicalswift
Copy link
Contributor Author

@kallewoof Good point! Fixed! :-)

@paveljanik
Copy link
Contributor

ACK d7723ab

Travis bug unrelated.

@kallewoof
Copy link
Contributor

utACK d7723ab

@practicalswift practicalswift force-pushed the remove-duplicate-includes branch from ff491fe to d7723ab Compare June 9, 2017 13:37
@practicalswift practicalswift force-pushed the remove-duplicate-includes branch from d7723ab to e53a0fa Compare June 9, 2017 13:39
@practicalswift
Copy link
Contributor Author

Triggered a new Travis build to get rid of the spurious build error.

@fanquake
Copy link
Member

fanquake commented Jun 9, 2017

re-utACK e53a0fa

@sipa
Copy link
Member

sipa commented Jun 9, 2017

utACK e53a0fa

@laanwj laanwj merged commit e53a0fa into bitcoin:master Jun 11, 2017
laanwj added a commit that referenced this pull request Jun 11, 2017
e53a0fa Remove duplicate includes (practicalswift)

Tree-SHA512: 5101afaf190ade3ffbea666ff5d0cb59d3e1dbdd9a3db3d91df7b51c13cc9f5a699438e8a753655365f6dc14529bc95883e715b5a6ab73158374e13ec311f70b
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 8, 2019
e53a0fa Remove duplicate includes (practicalswift)

Tree-SHA512: 5101afaf190ade3ffbea666ff5d0cb59d3e1dbdd9a3db3d91df7b51c13cc9f5a699438e8a753655365f6dc14529bc95883e715b5a6ab73158374e13ec311f70b
@practicalswift practicalswift deleted the remove-duplicate-includes branch April 10, 2021 19:31
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants