Skip to content

Address nits from per-utxo change #10558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sipa merged 2 commits into from
Jun 28, 2017
Merged

Address nits from per-utxo change #10558

sipa merged 2 commits into from
Jun 28, 2017

Conversation

@morcos
Copy link
Contributor

@morcos morcos commented Jun 8, 2017

@sipa the other nits from my review

@sipa
Copy link
Member

sipa commented Jun 8, 2017

utACK 567a8fb86878d69619925fb1b945d6613ce134ad

gmaxwell
gmaxwell approved these changes Jun 8, 2017
View reviewed changes
Copy link
Contributor

@gmaxwell gmaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@morcos
Copy link
Contributor Author

morcos commented Jun 8, 2017

Removed one of the comment changes to reflect new semantics of HaveCoinInCache from #10559

sipa
sipa reviewed Jun 13, 2017
View reviewed changes
src/coins.h Outdated
Copy link
Member

@sipa sipa Jun 13, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As pointed out in another PR, CCoinViewMemPool::HaveCoin would violate this (which has no effect as it isn't called anywhere).

@laanwj
Copy link
Member

laanwj commented Jun 23, 2017

Needs rebase

@morcos
Add belt-and-suspenders in DisconnectBlock
3c8a9ae 
These extra variables were previously checked before the move to per-txout database.
@morcos
Copy link
Contributor Author

morcos commented Jun 27, 2017

rebased again... this PR is slowly getting smaller and smaller :)

sipa
sipa reviewed Jun 27, 2017
View reviewed changes
src/coins.h Outdated
Copy link
Member

@sipa sipa Jun 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look like valid C++.

Copy link
Contributor Author

@morcos morcos Jun 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh....

@morcos
Copy link
Contributor Author

morcos commented Jun 27, 2017

fixed broken push

@sipa
Copy link
Member

sipa commented Jun 27, 2017

utACK 21d4afa

@laanwj
Copy link
Member

laanwj commented Jun 28, 2017

utACK 21d4afa

@sipa sipa merged commit 21d4afa into bitcoin:master Jun 28, 2017
sipa added a commit that referenced this pull request Jun 28, 2017
@sipa
Merge #10558: Address nits from per-utxo change
90a002e 
21d4afa Comment clarifications in coins.cpp (Alex Morcos)
3c8a9ae Add belt-and-suspenders in DisconnectBlock (Alex Morcos)

Tree-SHA512: d83e12ed71674faaaaebc03ffa1e2276984c35a29db419268ac9e14a45b33ccab716e3606dff8cfe1dcee4bec6e4794d2ca90341f10d5684be80e3fee61addf8
@morcos morcos deleted the 10195nits branch June 29, 2017 00:01
@bitcoin bitcoin deleted a comment from a415263 Jun 29, 2017
codablock pushed a commit to codablock/dash that referenced this pull request Oct 26, 2017
@sipa @codablock
Merge bitcoin#10558: Address nits from per-utxo change
48288d1 
21d4afa Comment clarifications in coins.cpp (Alex Morcos)
3c8a9ae Add belt-and-suspenders in DisconnectBlock (Alex Morcos)

Tree-SHA512: d83e12ed71674faaaaebc03ffa1e2276984c35a29db419268ac9e14a45b33ccab716e3606dff8cfe1dcee4bec6e4794d2ca90341f10d5684be80e3fee61addf8
codablock pushed a commit to codablock/dash that referenced this pull request Oct 31, 2017
@sipa @codablock
Merge bitcoin#10558: Address nits from per-utxo change
5b23216 
21d4afa Comment clarifications in coins.cpp (Alex Morcos)
3c8a9ae Add belt-and-suspenders in DisconnectBlock (Alex Morcos)

Tree-SHA512: d83e12ed71674faaaaebc03ffa1e2276984c35a29db419268ac9e14a45b33ccab716e3606dff8cfe1dcee4bec6e4794d2ca90341f10d5684be80e3fee61addf8
@dagurval dagurval mentioned this pull request May 21, 2018
Merged
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sipa sipa sipa left review comments

+1 more reviewer

@gmaxwell gmaxwell gmaxwell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

UTXO Db and Indexes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morcos @sipa @laanwj @gmaxwell