Fix bumpfee test after #10449 #10506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failure reported by Jorge Timón <[email protected]> bitcoin#10449 (comment)
Contributor
Author
|
Note travis didn't catch this because there isn't currently a travis configuration with qt, wallet, and tests all enabled. |
Member
|
ACK 8906a9a |
Contributor
|
This fixes the tests, tested ACK pr/10506/head 8906a9a |
Member
|
utACK 8906a9a, but verified it fixes the bug. Going to merge this quickly. |
sipa
added a commit
that referenced
this pull request
Jun 1, 2017
Contributor
|
Oh! Thanks for reporting and fixing. |
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jun 2, 2017
Currently these test failures are not caught by travis leading to bugs like: bitcoin#10506
Contributor
Author
We'll see, attempted in #10508. |
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jun 2, 2017
Currently these test failures are not caught by travis leading to bugs like: bitcoin#10506
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jun 5, 2017
Currently these test failures are not caught by travis leading to bugs like: bitcoin#10506
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jun 6, 2017
Currently these test failures are not caught by travis leading to bugs like: bitcoin#10506
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jun 6, 2017
Currently these test failures are not caught by travis leading to bugs like: bitcoin#10506
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jul 6, 2017
Currently these test failures are not caught by travis leading to bugs like: bitcoin#10506
laanwj
added a commit
that referenced
this pull request
Jul 25, 2017
4f92b5f Run Qt wallet tests on travis (Russell Yanofsky) Pull request description: Currently these test failures are not caught by travis leading to bugs like: #10506 Tree-SHA512: db1e4ff5b17bcd6fd000a3d21aa74f6b7e4c194e0663c1896a100612671910a7cdadd896b59642420ea016598895b54a8468914847ebefef105a3c47c311d4b2
mempko
pushed a commit
to meritlabs/merit
that referenced
this pull request
Sep 28, 2017
4f92b5f Run Qt wallet tests on travis (Russell Yanofsky) Pull request description: Currently these test failures are not caught by travis leading to bugs like: bitcoin/bitcoin#10506 Tree-SHA512: db1e4ff5b17bcd6fd000a3d21aa74f6b7e4c194e0663c1896a100612671910a7cdadd896b59642420ea016598895b54a8468914847ebefef105a3c47c311d4b2
sickpig
pushed a commit
to sickpig/BitcoinUnlimited
that referenced
this pull request
Oct 19, 2017
4f92b5f Run Qt wallet tests on travis (Russell Yanofsky) Pull request description: Currently these test failures are not caught by travis leading to bugs like: bitcoin/bitcoin#10506 Tree-SHA512: db1e4ff5b17bcd6fd000a3d21aa74f6b7e4c194e0663c1896a100612671910a7cdadd896b59642420ea016598895b54a8468914847ebefef105a3c47c311d4b2
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jun 23, 2019
Currently these test failures are not caught by travis leading to bugs like: bitcoin#10506
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Sep 23, 2019
4f92b5f Run Qt wallet tests on travis (Russell Yanofsky) Pull request description: Currently these test failures are not caught by travis leading to bugs like: bitcoin#10506 Tree-SHA512: db1e4ff5b17bcd6fd000a3d21aa74f6b7e4c194e0663c1896a100612671910a7cdadd896b59642420ea016598895b54a8468914847ebefef105a3c47c311d4b2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failure reported by @jtimon #10449 (comment)