build: silence gcc7's implicit fallthrough warning #10489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a well-intentioned but realistically annoying warning. Unfortunately, it's too easy for a warning in one header to cause dozens of repeated warnings.
Member
|
Yes, this one seems more trouble than it's worth (with Wshadow still fresh in the mind). utACK |
Member
|
utACK cf390df |
laanwj
added a commit
that referenced
this pull request
Jun 5, 2017
cf390df build: silence gcc7's implicit fallthrough warning (Cory Fields) Tree-SHA512: 330a4258161529c6e7af34ba3dc9703c24d897d7fff317c078441405c4546c7236e260603181001954b214d4640ad09ed3d34d3b518be991cb1712a02bcaa1d9
willwray
added a commit
to willwray/dash
that referenced
this pull request
Sep 13, 2017
This is a well-intentioned but realistically annoying warning. Unfortunately, it's too easy for a warning in one header to cause dozens of repeated warnings. bitcoin#10489
UdjinM6
pushed a commit
to dashpay/dash
that referenced
this pull request
Sep 14, 2017
This is a well-intentioned but realistically annoying warning. Unfortunately, it's too easy for a warning in one header to cause dozens of repeated warnings. bitcoin#10489
laanwj
added a commit
that referenced
this pull request
Nov 1, 2017
60b98f8 [Util] Update tinyformat.h (fanquake) Pull request description: Updates `tinyformat.h` to commit c42f/tinyformat@689695c upstream. Including: c42f/tinyformat@8a2812d c42f/tinyformat@5d9e05a c42f/tinyformat@48e2e48 @achow101 mentioned that since upgrading to Ubuntu 17.10 (GCC 7), tinyformat had been throwing lots of -Wimplicit-fallthrough warnings. However fallthrough warnings should have been silenced by #10489. cc @theuni. The upstream commit to fix fallthrough warnings is in this PR c42f/tinyformat#39. The last time tinyformat.h was updated in this repo was in #8274. Tree-SHA512: a51bd30544693550e08148daf5d244e3a3a410caff7897351eb9cd28f661dc85e193e045bb86068ee4006b2f89a7233b7573b8c50d93d2a9a15a11386fdcc605
AmirolAhmad
pushed a commit
to AmirolAhmad/gobytes-test
that referenced
this pull request
Dec 11, 2017
This is a well-intentioned but realistically annoying warning. Unfortunately, it's too easy for a warning in one header to cause dozens of repeated warnings. bitcoin/bitcoin#10489
AmirolAhmad
pushed a commit
to AmirolAhmad/gobytes-test
that referenced
this pull request
Dec 12, 2017
This is a well-intentioned but realistically annoying warning. Unfortunately, it's too easy for a warning in one header to cause dozens of repeated warnings. bitcoin/bitcoin#10489
sickpig
referenced
this pull request
in sickpig/BitcoinUnlimited
Jan 11, 2018
60b98f8 [Util] Update tinyformat.h (fanquake) Pull request description: Updates `tinyformat.h` to commit c42f/tinyformat@689695c upstream. Including: c42f/tinyformat@8a2812d c42f/tinyformat@5d9e05a c42f/tinyformat@48e2e48 @achow101 mentioned that since upgrading to Ubuntu 17.10 (GCC 7), tinyformat had been throwing lots of -Wimplicit-fallthrough warnings. However fallthrough warnings should have been silenced by #10489. cc @theuni. The upstream commit to fix fallthrough warnings is in this PR c42f/tinyformat#39. The last time tinyformat.h was updated in this repo was in #8274. Tree-SHA512: a51bd30544693550e08148daf5d244e3a3a410caff7897351eb9cd28f661dc85e193e045bb86068ee4006b2f89a7233b7573b8c50d93d2a9a15a11386fdcc605
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 16, 2020
60b98f8 [Util] Update tinyformat.h (fanquake) Pull request description: Updates `tinyformat.h` to commit c42f/tinyformat@689695c upstream. Including: c42f/tinyformat@8a2812d c42f/tinyformat@5d9e05a c42f/tinyformat@48e2e48 @achow101 mentioned that since upgrading to Ubuntu 17.10 (GCC 7), tinyformat had been throwing lots of -Wimplicit-fallthrough warnings. However fallthrough warnings should have been silenced by bitcoin#10489. cc @theuni. The upstream commit to fix fallthrough warnings is in this PR c42f/tinyformat#39. The last time tinyformat.h was updated in this repo was in bitcoin#8274. Tree-SHA512: a51bd30544693550e08148daf5d244e3a3a410caff7897351eb9cd28f661dc85e193e045bb86068ee4006b2f89a7233b7573b8c50d93d2a9a15a11386fdcc605
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a well-intentioned but realistically annoying warning. Unfortunately, it's too easy for a warning in one header to cause dozens of repeated warnings.
See here for details.
If it were just our code, I'd add in the (non-standard) annotations. But it's also an issue in leveldb and tinyformat, and would require substantial autoconf hackery to avoid.
Fwiw, None of the existing warnings turned up are real bugs.