add SeedNodes to CConnman::Options #10467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Pinging @theuni |
Author
fanquake
reviewed
May 30, 2017
src/net.cpp
Outdated
Member
There was a problem hiding this comment.
Can you change this to not introduce new Boost code.
fanquake
reviewed
May 30, 2017
src/init.cpp
Outdated
Member
There was a problem hiding this comment.
Even though your only moving this, if we're going to touch these lines, can you remove Boost.
Start of a series of changes to clean up the instantiation of connman by decoupling the command line arguments.
benma
force-pushed
the
connmannoptions_seednodes
branch
from
dee1831 to
5d67526
Compare
laanwj
added a commit
that referenced
this pull request
May 31, 2017
5d67526 add SeedNodes to CConnman::Options (Marko Bencun) Tree-SHA512: d732ab08697419f896d9598fa3c30030ddbe3b82a99a398d813ebcd5e1fc610ad1043fe0f4c51a7ec5c4d70ce93a9ac5a5c7a91fcaae046ec4f1f7c41523a360
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 24, 2019
5d67526 add SeedNodes to CConnman::Options (Marko Bencun) Tree-SHA512: d732ab08697419f896d9598fa3c30030ddbe3b82a99a398d813ebcd5e1fc610ad1043fe0f4c51a7ec5c4d70ce93a9ac5a5c7a91fcaae046ec4f1f7c41523a360
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start of a series of changes to clean up the instantiation of connman
by decoupling the command line arguments.