Make bitcoind invalid argument error message specific #10447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I guess most users already interpret utACK 8ec3a6bebb7c7d2a739e8827e3e0509638172504 |
Member
Author
Yeah.... "somewhere" :-) |
Member
|
utACK 8ec3a6b |
laanwj
commented
May 24, 2017
src/bitcoind.cpp
Outdated
Member
Author
There was a problem hiding this comment.
another realization - why are we checking for "bitcoin:" URLs at all bitcoind.cpp? Shouldn't they be treated as invalid tokens as well?
The current message is not helpful. Hardly anyone even remembers that bitcoind used to be a cli utility, let alone new users. Print what the actual problem is.
laanwj
force-pushed
the
2017_05_bitcoind_commandline_error
branch
from
8ec3a6b to
cd5622d
Compare
Member
|
utACK cd5622d |
1 similar comment
Contributor
|
utACK cd5622d |
laanwj
added a commit
that referenced
this pull request
Jun 1, 2017
cd5622d Make bitcoind invalid argument error message specific (Wladimir J. van der Laan) Tree-SHA512: 78999b9359685c4090f9a112e1d02bdddac22173f5f04600773b042acb9481ebb54d0f73d9d6d74249f845f497927a58d59de69bf33e3dccf096c3c80c7ebf6b
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 24, 2019
…cific cd5622d Make bitcoind invalid argument error message specific (Wladimir J. van der Laan) Tree-SHA512: 78999b9359685c4090f9a112e1d02bdddac22173f5f04600773b042acb9481ebb54d0f73d9d6d74249f845f497927a58d59de69bf33e3dccf096c3c80c7ebf6b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current message is not helpful. Hardly anyone even remembers that bitcoind used to be a cli utility, let alone new users. Print what the actual problem is.
Inspired by discussion here: #10402 (comment)
Also remove the check for
bitcoin:URIs. The expected output when accidentally passing abitcoin:URI tobitcoindinstead ofbitcoin-qtwould be an error not silent acceptance.