removed obsolete boost workaround (boost ticket #4258) #1043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I've also wondered about this tss line. But I was afraid to remove it, as Let's try if it does't break the gitian build... |
Author
|
While you are trying, I have another thing for you to test :) ... if you want. My build on Windows works great with "-fstack-protector-all" enabled :) (set in the .pro file). |
Member
|
ACK. I tested building in gitian. |
gavinandresen
added a commit
that referenced
this pull request
Apr 5, 2012
removed obsolete boost workaround (boost ticket #4258)
coblee
referenced
this pull request
in litecoin-project/litecoin
Jul 17, 2012
removed obsolete boost workaround (boost ticket bitcoin#4258)
sanch0panza
pushed a commit
to sanch0panza/bitcoin
that referenced
this pull request
May 17, 2018
1.3.0.0: Merge dev to release
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Oct 30, 2019
…e's inputs to the wallet 3a7ec7c [Tests] Add wallet_reorg-stake functional test to test_runner.py (random-zebra) a0285e4 [Wallet] Fix bug with coinstake inputs wrongly marked as spent (random-zebra) bb683c7 [Tests] Add wallet_reorg-stake functional test (random-zebra) 3eca8da [Core][Tests] REGTEST: fix nStakeModifier=0 (random-zebra) Pull request description: Additional bug introduced with the changes of bitcoin#970 (and not caught in bitcoin#1040 even though the culprit is the same: `GetDepthInMainChain` returning a value `0` when `-1` was expected). After a block reorganization, the coins used as coinstake inputs in the orphan chain were still marked as spent in the wallet. Thus there were inconsistencies in the balance (either displayed in the GUI or returned by `getbalance` via CLI) and missing utxos in the wallet (either accessed through coincontrol in the GUI or returned by `listunspent` via CLI). PIVX-Project@a0285e4 fixes it by marking as "spent" the inputs of not-in-mempool txes only for non-coinstakes (coinstakes don't hit the mempool so, when not in chain, their inputs should be considered unspent). PIVX-Project@bb683c7 Introduces the functional test `wallet_reorg-stake` to reproduce the issue. The test fails without PIVX-Project@a0285e4 and passes with it. ACKs for top commit: Warrows: ACK 3a7ec7c Tree-SHA512: 8f97e3d48720b776c84820e0ab8257665ac4c4c9d394db0e4b9f3a05b0904bf9f70cf54865338c4e29066e6b3670e9e90f77780d3ddd198e8e2b6e416c4cb49c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiles just fine on Windows ... you should try a compilation on Linux / Max and if it works accept this, otherwise close this one.
For reference: http://svn.boost.org/trac/boost/ticket/4258