Replace bytes_serialized with bogosize #10426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks like you'll need to update the blockchain RPC test here. |
Member
Author
|
Fixed. |
Member
|
Nice, concept ACK |
Member
|
Breaking changes need to be mentioned in the release notes. Mind to do it
in this pull?
…On Fri, May 19, 2017 at 2:37 AM, Pieter Wuille ***@***.***> wrote:
Fixed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#10426 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGGmv7RAjHs0G7ASE9mF7mNoTAKKXKPDks5r7ORfgaJpZM4Nf66O>
.
|
Member
Author
|
I've rebased this PR on top of #10396, as both touch the same code. A single combined release-notes.md entry was added. |
Member
Author
|
Rebased, and updated the release notes a bit. |
Member
Author
|
Rebased on top of #10195. |
maflcko
reviewed
Jun 2, 2017
src/rpc/blockchain.cpp
Outdated
Member
There was a problem hiding this comment.
Could you suffix the name here with _2 as you are touching the file anyway?
Member
|
tested ACK 8b22af3 |
laanwj
added a commit
that referenced
this pull request
Jun 6, 2017
8b22af3 Replace bytes_serialized with bogosize (Pieter Wuille) Tree-SHA512: e70a981bbb977329f9e324c45f9a1346ec9aacfbbad5474e608cdd1f852257502bb7db8003fd578260a609e45d1a9cf87ce96df9c4187d92d50f60a209e232ce
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 26, 2019
8b22af3 Replace bytes_serialized with bogosize (Pieter Wuille) Tree-SHA512: e70a981bbb977329f9e324c45f9a1346ec9aacfbbad5474e608cdd1f852257502bb7db8003fd578260a609e45d1a9cf87ce96df9c4187d92d50f60a209e232ce
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Aug 31, 2021
Summary: This is a backport of [[bitcoin/bitcoin#19328 | core#19328]] [2/4] bitcoin/bitcoin@a712cf6 Backport note: D507 kept the name `hash_serialized` instead of using `hash_serialized_2` which was introduced in [[bitcoin/bitcoin#10426 | core#10426]] Depends on D9978 Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Subscribers: majcosta Differential Revision: https://reviews.bitcoinabc.org/D9979
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current result: