Skip to content

Conversation

@spencerlievens
Copy link
Contributor

To keep conformity.

@jonasschnelli
Copy link
Contributor

sigh
utACK 56f09df

@TheBlueMatt
Copy link
Contributor

TheBlueMatt commented Apr 30, 2017

sigh

ACK

@kallewoof
Copy link
Contributor

utACK 56f09df

@laanwj
Copy link
Member

laanwj commented May 1, 2017

Meh.

To keep conformity.

Conformity to what? Is alphabetic sorting of compilation units documented in doc/developer-notes.md, or any other document?

@kallewoof
Copy link
Contributor

Local conformity? (All the other files in the list are in alphabetic order.)

@spencerlievens
Copy link
Contributor Author

spencerlievens commented May 3, 2017

@laanwj Conformity in the sense that the rest of the makefile is alphabetically sorted and that everyone seems to be conforming to that standard(well nearly everyone :P).

@jonasschnelli
Copy link
Contributor

jonasschnelli commented May 3, 2017

@laanwj Conformity in the sense that the rest of the makefile is alphabetically sorted and that everyone seems to be conforming to that standard(well nearly everyone :P).

Such pull requests improve almost nothing while they distract the development process of other important features and stealing time from reviewers and maintainers.

If you want to help, please improve something that has a positive net-outcome.

@laanwj
Copy link
Member

laanwj commented May 3, 2017

@laanwj Conformity in the sense that the rest of the makefile is alphabetically sorted and that everyone seems to be conforming to that standard(well nearly everyone :P).

Ok, fair enough, going to merge this one, but - as @jonasschnelli already says - please don't make a habit of it. Usually it's best to do these kind of changes when you're already adding/removing files in the first place.

@laanwj laanwj merged commit 56f09df into bitcoin:master May 3, 2017
laanwj added a commit that referenced this pull request May 3, 2017
56f09df [Makefile] Alphabetically Reorder addrdb.cpp (Spencer Lievens)

Tree-SHA512: cedf64f5b4a6b20c07881f7e9c1c36421ee04a1ba17319946bae0197f9475dba6d5bda05f8f5d72539fbffcaa0adf8f474ecb2089106215c996576ab1235e8e1
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 19, 2019
56f09df [Makefile] Alphabetically Reorder addrdb.cpp (Spencer Lievens)

Tree-SHA512: cedf64f5b4a6b20c07881f7e9c1c36421ee04a1ba17319946bae0197f9475dba6d5bda05f8f5d72539fbffcaa0adf8f474ecb2089106215c996576ab1235e8e1
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants