-
Notifications
You must be signed in to change notification settings - Fork 38.7k
[Makefile] Alphabetically Reorder addrdb.cpp #10302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To keep conformity.
|
sigh |
ACK |
|
utACK 56f09df |
|
Meh.
Conformity to what? Is alphabetic sorting of compilation units documented in |
|
Local conformity? (All the other files in the list are in alphabetic order.) |
|
@laanwj Conformity in the sense that the rest of the makefile is alphabetically sorted and that everyone seems to be conforming to that standard(well nearly everyone :P). |
Such pull requests improve almost nothing while they distract the development process of other important features and stealing time from reviewers and maintainers. If you want to help, please improve something that has a positive net-outcome. |
Ok, fair enough, going to merge this one, but - as @jonasschnelli already says - please don't make a habit of it. Usually it's best to do these kind of changes when you're already adding/removing files in the first place. |
56f09df [Makefile] Alphabetically Reorder addrdb.cpp (Spencer Lievens) Tree-SHA512: cedf64f5b4a6b20c07881f7e9c1c36421ee04a1ba17319946bae0197f9475dba6d5bda05f8f5d72539fbffcaa0adf8f474ecb2089106215c996576ab1235e8e1
56f09df [Makefile] Alphabetically Reorder addrdb.cpp (Spencer Lievens) Tree-SHA512: cedf64f5b4a6b20c07881f7e9c1c36421ee04a1ba17319946bae0197f9475dba6d5bda05f8f5d72539fbffcaa0adf8f474ecb2089106215c996576ab1235e8e1
To keep conformity.