Tests: Refactor to create witness script creation function #10223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jimmysong
commented
Apr 18, 2017
jimmysong
commented
- Refactor blocktools.py so that witness script creation is its own function
- Changed p2p-segwit to use new function
sdaftuar
approved these changes
Apr 18, 2017
Member
sdaftuar
left a comment
sdaftuar
left a comment
There was a problem hiding this comment.
utACK d6388fc6c7289409e60b0076e53823cb861eda5e
Contributor
|
Tested ACK e3b78aa. Looks good Jimmy. |
Contributor
Author
|
@MarcoFalke Glad to squash when you give me the go-ahead for merge. |
* Refactor blocktools.py so that witness script creation is its own function * Changed p2p-segwit to use new function
jimmysong
force-pushed
the
refactor_blocktools_for_segwit
branch
from
e3b78aa to
c39a6b9
Compare
Contributor
Author
|
squashed and rebased to master |
laanwj
added a commit
that referenced
this pull request
Apr 21, 2017
c39a6b9 Tests: Refactor to create witness script creation function (Jimmy Song) Tree-SHA512: 1dde621c811ea1a2719acb9a9b84825d3f520234da7fc4045da13754d4a6e6736de2fd508a2b6e64226ad95c7e634bf76d36bd0dcd1b37c63e7b1e172ee0816c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.