Remove SYNC_TRANSACTION_NOT_IN_BLOCK magic number #10186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
reviewed
Apr 11, 2017
Contributor
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
utACK 557495fa12ad8dbf2cba0a348be106ddde27348e
src/wallet/wallet.cpp
Outdated
Contributor
Author
There was a problem hiding this comment.
because SyncTransaction is only ever called by a function which uses the variable name pindex, and only uses that variable to call another function that uses the variable name pindex (actually pIndex). Changing the variable name in the middle of the stack seems unnecessary. And since I'm already touching these lines, I might as well.
I should have renamed this pindex, not pindexBlock. Doing that now.
jnewbery
force-pushed
the
remove_SYNC_TRANSACTION_NOT_IN_BLOCK_magic_number
branch
from
557495f to
d0cd0bd
Compare
Contributor
|
utACK d0cd0bd |
Member
|
utACK d0cd0bd |
laanwj
added a commit
that referenced
this pull request
Apr 13, 2017
d0cd0bd Make CWallet::SyncTransactions() interface friendlier (John Newbery) 714e4ad AddToWalletIfInvolvingMe should test pIndex, not posInBlock (John Newbery) Tree-SHA512: d02e7ffce635c53f3e099c37cc5613b431f74e0e3ea189269132901a99fc539477849ddad0282ce721d46a4d794c2d46523d58b64f0c26c655f70b5808c745a5
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
May 27, 2019
d0cd0bd Make CWallet::SyncTransactions() interface friendlier (John Newbery) 714e4ad AddToWalletIfInvolvingMe should test pIndex, not posInBlock (John Newbery) Tree-SHA512: d02e7ffce635c53f3e099c37cc5613b431f74e0e3ea189269132901a99fc539477849ddad0282ce721d46a4d794c2d46523d58b64f0c26c655f70b5808c745a5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested here: #9725 (comment)
@TheBlueMatt