Move zmq test skipping logic into individual test case. #10097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Concept ACK
…On Mon, Mar 27, 2017 at 6:15 PM, John Newbery ***@***.***> wrote:
This commit uses the new skip test funcationality added in
232b666
<232b666>
to skip the zmq tests if the
python zmq module is not available or if bitcoind has been built without
zmq support.
This removes the zmq-specific logic from test_runner.py. In general it's
better if test_runner.py has no knowledge of special cases for
individual tests and is a general purpose test runner.
------------------------------
You can view, comment on, or merge this pull request online at:
#10097
Commit Summary
- Move zmq test skipping logic into individual test case.
File Changes
- *M* test/functional/test_runner.py
<https://github.com/bitcoin/bitcoin/pull/10097/files#diff-0> (25)
- *M* test/functional/zmq_test.py
<https://github.com/bitcoin/bitcoin/pull/10097/files#diff-1> (21)
Patch Links:
- https://github.com/bitcoin/bitcoin/pull/10097.patch
- https://github.com/bitcoin/bitcoin/pull/10097.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#10097>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGGmv4BZGpuh9duLpkF5cPOQke7I_8zmks5rp-CdgaJpZM4MqfhX>
.
|
Member
|
Needs a rebase. Will test. |
Contributor
|
utACK |
Contributor
Author
|
rebased |
This commit uses the new skip test funcationality added in 232b666 to skip the zmq tests if the python zmq module is not available or if bitcoind has been built without zmq support. This removes the zmq-specific logic from test_runner.py. In general it's better if test_runner.py has no knowledge of special cases for individual tests and is a general purpose test runner.
Contributor
Author
|
rebased |
Member
|
utACK 6803e09 @jimmysong Thanks for testing. |
maflcko
pushed a commit
that referenced
this pull request
Apr 23, 2017
6803e09 Move zmq test skipping logic into individual test case. (John Newbery) Tree-SHA512: 9d166b53e9acf386c4dafc860b38e2901b331a7505bba9714a2f4e3bdef68b0316c8b76fddbfb620835ddee549cf32fffb3a96a19b0799ad94f2553f55f19a35
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 8, 2019
…t case. 6803e09 Move zmq test skipping logic into individual test case. (John Newbery) Tree-SHA512: 9d166b53e9acf386c4dafc860b38e2901b331a7505bba9714a2f4e3bdef68b0316c8b76fddbfb620835ddee549cf32fffb3a96a19b0799ad94f2553f55f19a35 s/bitcoind/dashd/ Signed-off-by: Pasta <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uses the new skip test funcationality added in
232b666 to skip the zmq tests if the
python zmq module is not available or if bitcoind has been built without
zmq support.
This removes the zmq-specific logic from test_runner.py. In general it's
better if test_runner.py has no knowledge of special cases for
individual tests and is a general purpose test runner.