Skip to content

Update bitcoin.conf with example for pruning #10090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maflcko merged 1 commit into from
Mar 31, 2017
Merged

Update bitcoin.conf with example for pruning #10090

maflcko merged 1 commit into from
Mar 31, 2017

Conversation

@coinables
Copy link
Contributor

@coinables coinables commented Mar 26, 2017

This option is becoming more popular recently, and I propose an example to be shown in the bitcoin.conf.

@fanquake fanquake added the Docs label Mar 26, 2017
@laanwj
Copy link
Member

laanwj commented Mar 27, 2017

Concept ACK on adding the example.

Explicitly mentioning 3GB is not a good idea. These numbers peppered around the documentation tend to get outdated sooner than later. The size of the UTXO set is growing every day, and that can't be pruned.

laanwj
laanwj reviewed Mar 27, 2017
View reviewed changes
contrib/debian/examples/bitcoin.conf Outdated
Copy link
Member

@laanwj laanwj Mar 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have the unit wrong, it's not in blocks but in MiB. Maybe you can borrow some description text from the help message:

  -prune=<n>
       Reduce storage requirements by enabling pruning (deleting) of old
       blocks. This allows the pruneblockchain RPC to be called to
       delete specific blocks, and enables automatic pruning of old
       blocks if a target size in MiB is provided. This mode is
       incompatible with -txindex and -rescan. Warning: Reverting this
       setting requires re-downloading the entire blockchain. (default:
       0 = disable pruning blocks, 1 = allow manual pruning via RPC,
       >550 = automatically prune block files to stay under the
       specified target size in MiB)

paveljanik
paveljanik suggested changes Mar 27, 2017
View reviewed changes
contrib/debian/examples/bitcoin.conf Outdated
Copy link
Contributor

@paveljanik paveljanik Mar 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requirements

contrib/debian/examples/bitcoin.conf Outdated
Copy link
Contributor

@paveljanik paveljanik Mar 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

550 is the minimum, but you describe entering 1...

contrib/debian/examples/bitcoin.conf Outdated
Copy link
Contributor

@paveljanik paveljanik Mar 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=550

@sipa
Copy link
Member

sipa commented Mar 29, 2017

ACK after squashing.

paveljanik
paveljanik suggested changes Mar 29, 2017
View reviewed changes
contrib/debian/examples/bitcoin.conf Outdated
Copy link
Contributor

@paveljanik paveljanik Mar 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space before "(". And please squash.

contrib/debian/examples/bitcoin.conf Outdated
Copy link
Contributor

@paveljanik paveljanik Mar 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requirments -> requirements

@coinables
Update bitcoin.conf with example for pruning
c0651cc 
This option is becoming more popular recently, and I propose an example to be shown in the bitcoin.conf.

pruning comments

updated and corrected pruning comments

Revised details on pruning in bitcoin.conf

Revised details on pruning in bitcoin.conf

spelling and space

spelling and space

add details on pruning in bitcoin.conf
@fanquake
Copy link
Member

fanquake commented Mar 31, 2017

utACK c0651cc

@maflcko maflcko merged commit c0651cc into bitcoin:master Mar 31, 2017
maflcko pushed a commit that referenced this pull request Mar 31, 2017
Merge #10090: Update bitcoin.conf with example for pruning
8e4f7e7 
c0651cc Update bitcoin.conf with example for pruning (Kyle Honeycutt)

Tree-SHA512: f27180ac5d5a4bd32c7a63de156ca14eb8068509e64d386ca84ee16d0dacfa8e1bab9a8e7b88175fae12c8d823f71f8705d413f224a15d5aa7cf059f416fa023
@laanwj
Copy link
Member

laanwj commented Mar 31, 2017

I think we should move this file somewhere else - doc/examples maybe? After all it is a general example of a bitcoin.conf and there is nothing debian-specific to it.

PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request May 23, 2019
@PastaPastaPasta
Merge bitcoin#10090: Update bitcoin.conf with example for pruning
c8a565d 
c0651cc Update bitcoin.conf with example for pruning (Kyle Honeycutt)

Tree-SHA512: f27180ac5d5a4bd32c7a63de156ca14eb8068509e64d386ca84ee16d0dacfa8e1bab9a8e7b88175fae12c8d823f71f8705d413f224a15d5aa7cf059f416fa023
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@laanwj laanwj laanwj left review comments

+1 more reviewer

@paveljanik paveljanik paveljanik requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@coinables @laanwj @sipa @fanquake @paveljanik @maflcko